* [pve-devel] [PATCH v2 manager] vzdump: allow backups from plugins
@ 2021-07-19 13:07 Oguz Bektas
2021-07-30 15:09 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Oguz Bektas @ 2021-07-19 13:07 UTC (permalink / raw)
To: pve-devel
remove type check for the specific plugins, instead we can deduce it
from the supported content type in config (this can only be set on
storages that declare to support backups). should also work with
external storage plugins.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
v1->v2:
* remove type check instead of adding btrfs to it
PVE/VZDump.pm | 3 ---
1 file changed, 3 deletions(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 46cb9e6d..b671ab19 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -100,9 +100,6 @@ sub storage_info {
my $scfg = PVE::Storage::storage_config($cfg, $storage);
my $type = $scfg->{type};
- die "can't use storage type '$type' for backup\n"
- if (!($type eq 'dir' || $type eq 'nfs' || $type eq 'glusterfs'
- || $type eq 'cifs' || $type eq 'cephfs' || $type eq 'pbs'));
die "can't use storage '$storage' for backups - wrong content type\n"
if (!$scfg->{content}->{backup});
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* [pve-devel] applied: Re: [PATCH v2 manager] vzdump: allow backups from plugins
2021-07-19 13:07 [pve-devel] [PATCH v2 manager] vzdump: allow backups from plugins Oguz Bektas
@ 2021-07-30 15:09 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-07-30 15:09 UTC (permalink / raw)
To: Proxmox VE development discussion, Oguz Bektas
On 19/07/2021 15:07, Oguz Bektas wrote:
> remove type check for the specific plugins, instead we can deduce it
> from the supported content type in config (this can only be set on
> storages that declare to support backups). should also work with
> external storage plugins.
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> v1->v2:
> * remove type check instead of adding btrfs to it
>
> PVE/VZDump.pm | 3 ---
> 1 file changed, 3 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-30 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-19 13:07 [pve-devel] [PATCH v2 manager] vzdump: allow backups from plugins Oguz Bektas
2021-07-30 15:09 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox