From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH] fix compressor loop-order
Date: Wed, 14 Jul 2021 18:52:04 +0200 [thread overview]
Message-ID: <20210714165204.262432-1-s.ivanov@proxmox.com> (raw)
commit dbac106eb6e3cff405e57c0bb6a6dbe3cf307c52 introduced a flaw in
the logic - once a file is downloaded the 'last;' statement exited the
inner loop iterating over the compoentens instead of the outer one
iterating over the compressors.
since both do not inherently depend on each other simply swap them.
noticed while trying to build a pmg-template in a clean environment
with full repository configuration (before the tests worked due to
leftover files in the infodir)
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
Sorry for the inconvenience!
DAB.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/DAB.pm b/DAB.pm
index b81321e..9282789 100644
--- a/DAB.pm
+++ b/DAB.pm
@@ -648,8 +648,8 @@ sub initialize {
warn "Release info ignored\n";
};
- foreach my $compressor (@$COMPRESSORS) {
- foreach my $comp (@{$ss->{comp}}) {
+ foreach my $comp (@{$ss->{comp}}) {
+ foreach my $compressor (@$COMPRESSORS) {
$path = "dists/$ss->{suite}/$comp/binary-$arch/Packages.$compressor->{ext}";
$target = "$infodir/" . __url_to_filename ("$ss->{source}/$path");
my $pkgsrc = "$src/$path";
--
2.30.2
next reply other threads:[~2021-07-14 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 16:52 Stoiko Ivanov [this message]
2021-07-15 9:31 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714165204.262432-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox