From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 5/5 v2] dc options: Allow both package_update options
Date: Wed, 14 Jul 2021 12:09:33 +0200 [thread overview]
Message-ID: <20210714100933.54491-5-d.jaeger@proxmox.com> (raw)
In-Reply-To: <20210714100933.54491-1-d.jaeger@proxmox.com>
When opened for the first time (undefined value in datacenter.cfg) we should
allow setting both options yes and no for the package_update checkbox.
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
v2: new
www/manager6/dc/OptionView.js | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index ec6ff1a3..de7cbce9 100644
--- a/www/manager6/dc/OptionView.js
+++ b/www/manager6/dc/OptionView.js
@@ -35,6 +35,17 @@ Ext.define('PVE.dc.OptionView', {
Ext.Array.each(this.query('inputpanel'), function(panel) {
panel.setValues(edit_value);
+
+ if (name === 'notify') {
+ // Default depends on subscription status.
+ // Therefore, when datacenter.cfg contains nothing
+ // about package updates then allow setting both yes
+ // and no for it.
+ if (!edit_value || typeof edit_value.package_updates === 'undefined') {
+ const field = panel.down('field[name=package_updates]');
+ field.isDirty = () => true;
+ }
+ }
});
},
url: opts.url,
--
2.30.2
prev parent reply other threads:[~2021-07-14 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 10:09 [pve-devel] [PATCH cluster 1/5 v2] Close #1295: Add notifications to datacenter schema Dominic Jäger
2021-07-14 10:09 ` [pve-devel] [PATCH manager 2/5 v2] apt update: Inform users about missing subscriptions Dominic Jäger
2021-07-14 10:09 ` [pve-devel] [PATCH manager 3/5 v2] Close #1295: Make apt notifications configurable Dominic Jäger
2021-07-14 10:09 ` [pve-devel] [PATCH manager 4/5 v2] dc options: Add apt notifications GUI checkbox Dominic Jäger
2021-07-14 10:09 ` Dominic Jäger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714100933.54491-5-d.jaeger@proxmox.com \
--to=d.jaeger@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox