From: Oguz Bektas <o.bektas@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers
Date: Wed, 14 Jul 2021 11:51:51 +0200 [thread overview]
Message-ID: <20210714095151.138084-1-o.bektas@proxmox.com> (raw)
unmanaged containers should run the unified cgroupv2 code from our base
plugin so that they can start correctly instead of erroring out
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
v2-> v3:
* added comment from stoiko's reply
src/PVE/LXC/Setup.pm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm
index 9abdc85..4408dcc 100644
--- a/src/PVE/LXC/Setup.pm
+++ b/src/PVE/LXC/Setup.pm
@@ -424,6 +424,10 @@ sub get_ct_os_release {
sub unified_cgroupv2_support {
my ($self) = @_;
+ # code in base plugin is a generic check and should work
+ # for most distributions
+ $self->{plugin} //= 'PVE::LXC::Setup::Base'; # unmanaged
+
$self->protected_call(sub {
$self->{plugin}->unified_cgroupv2_support();
});
--
2.30.2
next reply other threads:[~2021-07-14 9:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 9:51 Oguz Bektas [this message]
2021-07-20 11:29 ` Oguz Bektas
2021-07-20 11:44 ` Thomas Lamprecht
2021-07-20 11:40 ` Wolfgang Bumiller
2021-07-20 11:49 ` Thomas Lamprecht
2021-07-20 11:51 ` Oguz Bektas
2021-07-20 11:59 ` Thomas Lamprecht
2021-07-20 12:08 ` Wolfgang Bumiller
2021-07-20 11:50 ` Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714095151.138084-1-o.bektas@proxmox.com \
--to=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox