From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Oguz Bektas <o.bektas@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 container] fix #3516: fix unmanaged containers
Date: Tue, 13 Jul 2021 15:49:06 +0200 [thread overview]
Message-ID: <20210713154906.3952b5cb@rosa.proxmox.com> (raw)
In-Reply-To: <20210713123333.939899-1-o.bektas@proxmox.com>
Thanks for providing the patch!
code-wise LGTM - and it fixes the issue in my reproducer
(a buster container where I manually changed the ostype to unmanaged)
I think it would help to have a small comment above the line you inserted
stating something like:
# the code in PVE::LXC::Setup::Base is a generic check and should also
# work for most other distros
apart from that:
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com>
On Tue, 13 Jul 2021 14:33:33 +0200
Oguz Bektas <o.bektas@proxmox.com> wrote:
> unmanaged containers should run the unified cgroupv2 code from our base
> plugin so that they can start correctly instead of erroring out
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> v1->v2:
> * run code from base plugin instead of skipping it completely
>
>
> src/PVE/LXC/Setup.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm
> index 9abdc85..c4c73e1 100644
> --- a/src/PVE/LXC/Setup.pm
> +++ b/src/PVE/LXC/Setup.pm
> @@ -424,6 +424,8 @@ sub get_ct_os_release {
> sub unified_cgroupv2_support {
> my ($self) = @_;
>
> + $self->{plugin} //= 'PVE::LXC::Setup::Base'; # unmanaged
> +
> $self->protected_call(sub {
> $self->{plugin}->unified_cgroupv2_support();
> });
prev parent reply other threads:[~2021-07-13 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 12:33 Oguz Bektas
2021-07-13 13:49 ` Stoiko Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713154906.3952b5cb@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox