public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer] unconfigured.sh: drop networking stop upon reboot
Date: Mon, 12 Jul 2021 10:32:48 +0200	[thread overview]
Message-ID: <20210712083248.1736674-1-s.ivanov@proxmox.com> (raw)

This is (afaics) a purely cosmetic change.

With PVE 7.0 the ISO does not ship ifupdown/ifupdown2 in the installer
environment anymore - ifup/ifdown are currently provided by busybox.

Since we stop all daemonized processes with killall5, this takes care
of the dhclient instances - so just drop the invocation of the non
existing script.

Noticed while checking out 2 improvments to the installer.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 unconfigured.sh | 2 --
 1 file changed, 2 deletions(-)

diff --git a/unconfigured.sh b/unconfigured.sh
index 98b8d9c..35ec0ee 100755
--- a/unconfigured.sh
+++ b/unconfigured.sh
@@ -47,8 +47,6 @@ eject_and_reboot() {
 real_reboot() {
     trap - ERR
 
-    /etc/init.d/networking stop
-
     # stop udev (release file handles)
     /etc/init.d/udev stop
 
-- 
2.30.2





             reply	other threads:[~2021-07-12  8:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12  8:32 Stoiko Ivanov [this message]
2021-07-12 10:02 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210712083248.1736674-1-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal