* [pve-devel] [PATCH zfsonlinux 0/2] update to 2.0.5 and follow-up on the last cleanup
@ 2021-07-09 15:41 Stoiko Ivanov
2021-07-09 15:41 ` [pve-devel] [PATCH zfsonlinux 1/2] do not restart most services upon upgrade Stoiko Ivanov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2021-07-09 15:41 UTC (permalink / raw)
To: pve-devel
This patchset follows-up on the last cleanup I sent:
https://lists.proxmox.com/pipermail/pve-devel/2021-June/048802.html
I decided to drop the symbols-file generation for now - since it adds
complexity, and I am not aware of any package which would benefit from it.
Currently all our zfs packages depend on the libraries in the same version -
thus they need to get upgraded along with e.g. zfsutils-linux - which feels to
me a bit more robust - Additionally it seems like ZFS 2.1 added some breaking
abi changes - which would need to be reflected in new library package names
anyways.
Will gladly send the symbols-files should anyone object, or see a benefit in
having them.
Additionally I updated the submodule to ZFS 2.0.5, which should contain the
fix for https://bugzilla.proxmox.com/show_bug.cgi?id=2546
minimal tests in a VM running pve 7 were done (ztest, created a bullseye
container, snapshotted it and rolled back).
Stoiko Ivanov (2):
do not restart most services upon upgrade
update submodule and patches to ZFS 2.0.5
debian/rules | 8 ++++++++
upstream | 2 +-
2 files changed, 9 insertions(+), 1 deletion(-)
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] [PATCH zfsonlinux 1/2] do not restart most services upon upgrade
2021-07-09 15:41 [pve-devel] [PATCH zfsonlinux 0/2] update to 2.0.5 and follow-up on the last cleanup Stoiko Ivanov
@ 2021-07-09 15:41 ` Stoiko Ivanov
2021-07-09 15:41 ` [pve-devel] [PATCH zfsonlinux 2/2] update submodule and patches to ZFS 2.0.5 Stoiko Ivanov
2021-07-12 6:38 ` [pve-devel] applied-series: [PATCH zfsonlinux 0/2] update to 2.0.5 and follow-up on the last cleanup Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2021-07-09 15:41 UTC (permalink / raw)
To: pve-devel
zfs-zed is the only classical daemon, which benefits from a restart,
so restart only zfs-zed.
Noticed during the transition from ZFS 0.8.x to 2.0.0 zvol_wait, which
is called by zfs-volume-wait.service was changed to also output the
redacted_snap property of the datasets. This property does not exist
if the kernelmodule is still 0.8.x, causing an error to be printed to
the journal.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
debian/rules | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/debian/rules b/debian/rules
index e5166882..826bdc98 100755
--- a/debian/rules
+++ b/debian/rules
@@ -107,6 +107,14 @@ override_dh_install:
override_dh_missing:
dh_missing --fail-missing
+override_dh_installsystemd:
+ # these to lines prevent the restarting of all systemd services, except
+ # zfs-zed - they should not be restarted (importing, mounting, creating
+ # links in /dev, and can cause erros in the log
+ # (upon major.minor change)
+ dh_installsystemd --no-stop-on-upgrade -X zfs-zed.service
+ dh_installsystemd --name zfs-zed
+
override_dh_installdocs:
dh_installdocs
ifeq (,$(findstring nodoc, $(DEB_BUILD_OPTIONS)))
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] [PATCH zfsonlinux 2/2] update submodule and patches to ZFS 2.0.5
2021-07-09 15:41 [pve-devel] [PATCH zfsonlinux 0/2] update to 2.0.5 and follow-up on the last cleanup Stoiko Ivanov
2021-07-09 15:41 ` [pve-devel] [PATCH zfsonlinux 1/2] do not restart most services upon upgrade Stoiko Ivanov
@ 2021-07-09 15:41 ` Stoiko Ivanov
2021-07-12 6:38 ` [pve-devel] applied-series: [PATCH zfsonlinux 0/2] update to 2.0.5 and follow-up on the last cleanup Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2021-07-09 15:41 UTC (permalink / raw)
To: pve-devel
fixes #2546
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
upstream | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/upstream b/upstream
index 6150fbe6..e9353bc2 160000
--- a/upstream
+++ b/upstream
@@ -1 +1 @@
-Subproject commit 6150fbe67f7a9485eaabbca7df9a66852cda6892
+Subproject commit e9353bc2ef27c300281574453e0cf5189a375680
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied-series: [PATCH zfsonlinux 0/2] update to 2.0.5 and follow-up on the last cleanup
2021-07-09 15:41 [pve-devel] [PATCH zfsonlinux 0/2] update to 2.0.5 and follow-up on the last cleanup Stoiko Ivanov
2021-07-09 15:41 ` [pve-devel] [PATCH zfsonlinux 1/2] do not restart most services upon upgrade Stoiko Ivanov
2021-07-09 15:41 ` [pve-devel] [PATCH zfsonlinux 2/2] update submodule and patches to ZFS 2.0.5 Stoiko Ivanov
@ 2021-07-12 6:38 ` Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2021-07-12 6:38 UTC (permalink / raw)
To: Proxmox VE development discussion, Stoiko Ivanov
On 09.07.21 17:41, Stoiko Ivanov wrote:
> This patchset follows-up on the last cleanup I sent:
> https://lists.proxmox.com/pipermail/pve-devel/2021-June/048802.html
> I decided to drop the symbols-file generation for now - since it adds
> complexity, and I am not aware of any package which would benefit from it.
> Currently all our zfs packages depend on the libraries in the same version -
> thus they need to get upgraded along with e.g. zfsutils-linux - which feels to
> me a bit more robust - Additionally it seems like ZFS 2.1 added some breaking
> abi changes - which would need to be reflected in new library package names
> anyways.
> Will gladly send the symbols-files should anyone object, or see a benefit in
> having them.
>
> Additionally I updated the submodule to ZFS 2.0.5, which should contain the
> fix for https://bugzilla.proxmox.com/show_bug.cgi?id=2546
>
> minimal tests in a VM running pve 7 were done (ztest, created a bullseye
> container, snapshotted it and rolled back).
>
>
> Stoiko Ivanov (2):
> do not restart most services upon upgrade
> update submodule and patches to ZFS 2.0.5
>
> debian/rules | 8 ++++++++
> upstream | 2 +-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
applied series, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-12 6:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 15:41 [pve-devel] [PATCH zfsonlinux 0/2] update to 2.0.5 and follow-up on the last cleanup Stoiko Ivanov
2021-07-09 15:41 ` [pve-devel] [PATCH zfsonlinux 1/2] do not restart most services upon upgrade Stoiko Ivanov
2021-07-09 15:41 ` [pve-devel] [PATCH zfsonlinux 2/2] update submodule and patches to ZFS 2.0.5 Stoiko Ivanov
2021-07-12 6:38 ` [pve-devel] applied-series: [PATCH zfsonlinux 0/2] update to 2.0.5 and follow-up on the last cleanup Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox