* [pve-devel] [PATCH manager] API: Tasks: add more fields to return schema
@ 2021-07-09 14:09 Dominik Csapak
2021-07-13 4:36 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-07-09 14:09 UTC (permalink / raw)
To: pve-devel
so that they are documented and get displayed by pvesh/pvenode
all those fields must exists (since they come from the upid)
aside from the exitstatus, so marking that as optional
forum user reported that they are missing:
https://forum.proxmox.com/threads/ergebnis-eines-tasks-per-api-abfragen.92267/
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
PVE/API2/Tasks.pm | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/PVE/API2/Tasks.pm b/PVE/API2/Tasks.pm
index 085f9b95..056b698b 100644
--- a/PVE/API2/Tasks.pm
+++ b/PVE/API2/Tasks.pm
@@ -418,6 +418,28 @@ __PACKAGE__->register_method({
status => {
type => 'string', enum => ['running', 'stopped'],
},
+ type => {
+ type => 'string',
+ },
+ id => {
+ type => 'string',
+ },
+ user => {
+ type => 'string',
+ },
+ exitstatus => {
+ type => 'string',
+ optional => 1,
+ },
+ upid => {
+ type => 'string',
+ },
+ starttime => {
+ type => 'number',
+ },
+ node => {
+ type => 'string',
+ },
},
},
code => sub {
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] API: Tasks: add more fields to return schema
2021-07-09 14:09 [pve-devel] [PATCH manager] API: Tasks: add more fields to return schema Dominik Csapak
@ 2021-07-13 4:36 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-07-13 4:36 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 09.07.21 16:09, Dominik Csapak wrote:
> so that they are documented and get displayed by pvesh/pvenode
> all those fields must exists (since they come from the upid)
> aside from the exitstatus, so marking that as optional
>
> forum user reported that they are missing:
> https://forum.proxmox.com/threads/ergebnis-eines-tasks-per-api-abfragen.92267/
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> PVE/API2/Tasks.pm | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-13 4:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 14:09 [pve-devel] [PATCH manager] API: Tasks: add more fields to return schema Dominik Csapak
2021-07-13 4:36 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox