public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit] node: repos: only show suites warning at the top if enabled repository is affected
Date: Fri,  9 Jul 2021 10:08:22 +0200	[thread overview]
Message-ID: <20210709080822.25576-1-f.ebner@proxmox.com> (raw)

The warning still shows up for the disabled repository itself, but
having a disabled repository with a bad suite is not problematic for
the configuration status as a whole.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 src/node/APTRepositories.js | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
index 4a37adb..c7222fc 100644
--- a/src/node/APTRepositories.js
+++ b/src/node/APTRepositories.js
@@ -665,9 +665,6 @@ Ext.define('Proxmox.node.APTRepositories', {
 			(info.kind === 'ignore-pre-upgrade-warning' && !repoGrid.majorUpgradeAllowed)
 		    ) {
 			infos[path][idx].warnings.push(info);
-			if (!suitesWarning && info.property === 'Suites') {
-			    suitesWarning = true;
-			}
 		    } else {
 			throw 'unknown info';
 		    }
@@ -682,6 +679,10 @@ Ext.define('Proxmox.node.APTRepositories', {
 			if (infos[file.path] && infos[file.path][n]) {
 			    repo.Origin = infos[file.path][n].origin || Proxmox.Utils.UnknownText;
 			    repo.warnings = infos[file.path][n].warnings || [];
+
+			    if (repo.Enabled && repo.warnings.some(w => w.property === 'Suites')) {
+				suitesWarning = true;
+			    }
 			}
 			gridData.push(repo);
 		    }
-- 
2.30.2





             reply	other threads:[~2021-07-09  8:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09  8:08 Fabian Ebner [this message]
2021-07-09 12:43 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210709080822.25576-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal