From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: dc/AuthEditOpenId: remove unnecessary code
Date: Wed, 7 Jul 2021 13:54:37 +0200 [thread overview]
Message-ID: <20210707115437.23670-1-d.csapak@proxmox.com> (raw)
we do not have a 'verify' field here, so the onGetValues override
falsely sent 'delete: verify' on every edit
while our api is ok with that, it's better to remove it
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/dc/AuthEditOpenId.js | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/www/manager6/dc/AuthEditOpenId.js b/www/manager6/dc/AuthEditOpenId.js
index 7ebb9c8f..2dd60d1b 100644
--- a/www/manager6/dc/AuthEditOpenId.js
+++ b/www/manager6/dc/AuthEditOpenId.js
@@ -3,19 +3,6 @@ Ext.define('PVE.panel.OpenIDInputPanel', {
xtype: 'pveAuthOpenIDPanel',
mixins: ['Proxmox.Mixin.CBind'],
- onGetValues: function(values) {
- let me = this;
-
- if (!values.verify) {
- if (!me.isCreate) {
- Proxmox.Utils.assemble_field_data(values, { 'delete': 'verify' });
- }
- delete values.verify;
- }
-
- return me.callParent([values]);
- },
-
columnT: [
{
xtype: 'textfield',
--
2.30.2
reply other threads:[~2021-07-07 11:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210707115437.23670-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox