[pve-devel] [PATCH qemu-server] cfg2cmd: avoid io_uring with LVM and write{back, through} cache

[pve-devel] [PATCH qemu-server] cfg2cmd: avoid io_uring with LVM and write{back, through} cache

[Fabian Ebner]

Reported in the community forum[0]. Also tried with LVM-thin, but it
doesn't seem to be affected.

See also 628937f53acde52f7257ca79f574c87a45f392e7 for the same fix for
krbd.

[0]: https://forum.proxmox.com/threads/after-upgrade-to-7-0-all-vms-dont-boot.92019/post-401017

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 8fc90e2..b0fe257 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -1605,8 +1605,11 @@ sub print_drive_commandline_full {
     # io_uring with cache mode writeback or writethrough on krbd will hang...
     my $rbd_no_io_uring = $scfg && $scfg->{type} eq 'rbd' && $scfg->{krbd} && !$cache_direct;
 
+    # io_uring with cache mode writeback or writethrough on LVM will hang...
+    my $lvm_no_io_uring = $scfg && $scfg->{type} eq 'lvm' && !$cache_direct;
+
     if (!$drive->{aio}) {
-	if ($io_uring && !$rbd_no_io_uring) {
+	if ($io_uring && !$rbd_no_io_uring && !$lvm_no_io_uring) {
 	    # io_uring supports all cache modes
 	    $opts .= ",aio=io_uring";
 	} else {
-- 
2.30.2

[pve-devel] applied: [PATCH qemu-server] cfg2cmd: avoid io_uring with LVM and write{back, through} cache

[Thomas Lamprecht]

On 07.07.21 13:28, Fabian Ebner wrote:
> Reported in the community forum[0]. Also tried with LVM-thin, but it
> doesn't seem to be affected.
> 
> See also 628937f53acde52f7257ca79f574c87a45f392e7 for the same fix for
> krbd.
> 
> [0]: https://forum.proxmox.com/threads/after-upgrade-to-7-0-all-vms-dont-boot.92019/post-401017
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  PVE/QemuServer.pm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
>

applied, thanks!