[pve-devel] [PATCH manager] pve6to7: add check for 'lxc.cgroup.' keys in container config

[pve-devel] [PATCH manager] pve6to7: add check for 'lxc.cgroup.' keys in container config

[Stoiko Ivanov]

The check is rather straight forward - and might help users who
passthrough devices to their containers.

Reported in our community forum:
https://forum.proxmox.com/threads/pve-7-0-lxc-intel-quick-sync-passtrough-not-working-anymore.92025/

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
Tested quickly by pasting the lxc.cgroup.devices keys from the thread into a
container config.

PVE/CLI/pve6to7.pm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/PVE/CLI/pve6to7.pm b/PVE/CLI/pve6to7.pm
index 629d6935..a4a0bc67 100644
--- a/PVE/CLI/pve6to7.pm
+++ b/PVE/CLI/pve6to7.pm
@@ -995,6 +995,30 @@ sub check_containers_cgroup_compat {
     }
 };
 
+sub check_lxc_conf_keys {
+    my $kernel_cli = PVE::Tools::file_get_contents('/proc/cmdline');
+    if ($kernel_cli =~ /systemd.unified_cgroup_hierarchy=0/){
+	log_skip("System explicitly configured for legacy hybrid cgroup hierarchy.");
+	return;
+    }
+
+    log_info("Checking container configs for deprecated lxc.cgroup entries");
+
+    my $affected_ct = [];
+    my $cts = PVE::LXC::config_list();
+    for my $vmid (sort { $a <=> $b } keys %$cts) {
+	my $lxc_raw_conf = PVE::LXC::Config->load_config($vmid)->{lxc};
+	push @$affected_ct, "CT $vmid"  if (grep (@$_[0] =~ /^lxc\.cgroup\./, @$lxc_raw_conf));
+    }
+    if (scalar($affected_ct->@*) > 0) {
+	log_warn("Config of the following containers contains 'lxc.cgroup' keys, which will be ".
+	    "ignored in a unified cgroupv2 system:\n" .
+	    join(", ", $affected_ct->@*));
+    } else {
+	log_pass("No legacy 'lxc.cgroup' keys found.");
+    }
+}
+
 sub check_misc {
     print_header("MISCELLANEOUS CHECKS");
     my $ssh_config = eval { PVE::Tools::file_get_contents('/root/.ssh/config') };
@@ -1090,6 +1114,7 @@ sub check_misc {
     check_custom_pool_roles();
     check_description_lengths();
     check_storage_content();
+    check_lxc_conf_keys();
 }
 
 __PACKAGE__->register_method ({
-- 
2.30.2

[pve-devel] applied: [PATCH manager] pve6to7: add check for 'lxc.cgroup.' keys in container config

[Thomas Lamprecht]

On 07.07.21 10:44, Stoiko Ivanov wrote:
> The check is rather straight forward - and might help users who
> passthrough devices to their containers.
> 
> Reported in our community forum:
> https://forum.proxmox.com/threads/pve-7-0-lxc-intel-quick-sync-passtrough-not-working-anymore.92025/
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> Tested quickly by pasting the lxc.cgroup.devices keys from the thread into a
> container config.
> 
> PVE/CLI/pve6to7.pm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
>

applied, thanks!

But I merged it into the (now renamed) note length check to avoid iterating and parsing
all CT config multiple times.