[pve-devel] [PATCH storage] lvm: wipe signatures on lvcreate

[pve-devel] [PATCH storage] lvm: wipe signatures on lvcreate

[Stoiko Ivanov]

With PVE 7.0 we use upstream's lvm2 packages, which seem to detect
'more' signatures (and refuse creating lvs when they are present)

This prevents creating new disks on LVM (thick) storages as reported
on pve-user [0].

Adding -Wy to wipe signatures, and --yes (to actually wipe them
instead of prompting) fixes the aborted lvcreate.

Adding only to LVMPlugin and not to the lvcreate calls in
LvmThinPlugin, since I assume (and my quick tests confirm) that thin
pools are not affected by this issue..

Tested on a virtual test-setup with a LVM storage on a (virtual) iscsi
target and a local lvmthin storage.

[0] https://lists.proxmox.com/pipermail/pve-user/2021-July/172660.html

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 PVE/Storage/LVMPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Storage/LVMPlugin.pm b/PVE/Storage/LVMPlugin.pm
index 039bfc1..139d391 100644
--- a/PVE/Storage/LVMPlugin.pm
+++ b/PVE/Storage/LVMPlugin.pm
@@ -330,7 +330,7 @@ sub lvcreate {
 	$size .= "k"; # default to kilobytes
     }
 
-    my $cmd = ['/sbin/lvcreate', '-aly', '--size', $size, '--name', $name];
+    my $cmd = ['/sbin/lvcreate', '-aly', '-Wy', '--yes', '--size', $size, '--name', $name];
     for my $tag (@$tags) {
 	push @$cmd, '--addtag', $tag;
     }
-- 
2.30.2

[pve-devel] applied: [PATCH storage] lvm: wipe signatures on lvcreate

[Thomas Lamprecht]

On 06.07.21 11:50, Stoiko Ivanov wrote:
> With PVE 7.0 we use upstream's lvm2 packages, which seem to detect
> 'more' signatures (and refuse creating lvs when they are present)
> 
> This prevents creating new disks on LVM (thick) storages as reported
> on pve-user [0].
> 
> Adding -Wy to wipe signatures, and --yes (to actually wipe them
> instead of prompting) fixes the aborted lvcreate.
> 
> Adding only to LVMPlugin and not to the lvcreate calls in
> LvmThinPlugin, since I assume (and my quick tests confirm) that thin
> pools are not affected by this issue..
> 
> Tested on a virtual test-setup with a LVM storage on a (virtual) iscsi
> target and a local lvmthin storage.
> 
> [0] https://lists.proxmox.com/pipermail/pve-user/2021-July/172660.html
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  PVE/Storage/LVMPlugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!