From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage] cifs: fix adding storage without username in the GUI
Date: Mon, 5 Jul 2021 20:51:50 +0200 [thread overview]
Message-ID: <20210705185150.889830-1-s.ivanov@proxmox.com> (raw)
Currently when trying to add a CIFS storage, without providing a
username and passwort it fails while trying to mount the share, due to
the provided 'username=' parameter (w/o actual username).
I think the issue was introduced in
72385de9e23df9f8e438d74ff783a8075f8d1560
with the extracting of sensitive parameters we (rightly) switched to a
definedness check instead of one for truthyness - but an empty
username/password is defined.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
PVE/Storage/CIFSPlugin.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm
index 9d69b01..f8e173d 100644
--- a/PVE/Storage/CIFSPlugin.pm
+++ b/PVE/Storage/CIFSPlugin.pm
@@ -157,7 +157,7 @@ sub check_config {
sub on_add_hook {
my ($class, $storeid, $scfg, %param) = @_;
- if (defined($param{password})) {
+ if (defined($param{password}) && $param{password}) {
cifs_set_credentials($param{password}, $storeid);
if (!exists($scfg->{username})) {
warn "ignoring password parameter\n";
@@ -174,7 +174,7 @@ sub on_update_hook {
return if !exists($param{password});
- if (defined($param{password})) {
+ if (defined($param{password}) && $param{password}) {
cifs_set_credentials($param{password}, $storeid);
if (!exists($scfg->{username})) {
warn "ignoring password parameter\n";
--
2.30.2
next reply other threads:[~2021-07-05 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 18:51 Stoiko Ivanov [this message]
2021-07-06 5:45 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705185150.889830-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox