From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 4/4] node/Tasks: add 'clear filter' button
Date: Mon, 5 Jul 2021 16:34:02 +0200 [thread overview]
Message-ID: <20210705143402.2362828-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210705143402.2362828-1-d.csapak@proxmox.com>
that does two things,
show the user that some filters are active (even if filters are collapsed),
and let the user to reset the filters all at once
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/node/Tasks.js | 55 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 55 insertions(+)
diff --git a/src/node/Tasks.js b/src/node/Tasks.js
index dfe93dc..aa074b4 100644
--- a/src/node/Tasks.js
+++ b/src/node/Tasks.js
@@ -89,6 +89,13 @@ Ext.define('Proxmox.node.Tasks', {
let vm = me.getViewModel();
vm.set('showFilter', pressed);
},
+
+ clearFilter: function() {
+ let me = this;
+ me.lookup('filtertoolbar').query('field').forEach((field) => {
+ field.setValue(undefined);
+ });
+ },
},
listeners: {
@@ -140,6 +147,44 @@ Ext.define('Proxmox.node.Tasks', {
return params;
},
+ filterCount: function(get) {
+ let count = 0;
+ if (get('typefilter')) {
+ count++;
+ }
+ let status = get('statusfilter');
+ if ((Ext.isArray(status) && status.length > 0) ||
+ (!Ext.isArray(status) && status)) {
+ count++;
+ }
+ if (get('since')) {
+ count++;
+ }
+ if (get('until')) {
+ count++;
+ }
+
+ if (get('extraFilter')) {
+ let extraFilter = get('extraFilter');
+ for (const value of Object.values(extraFilter)) {
+ if (value !== undefined && value !== null && value !== "") {
+ count++;
+ }
+ }
+ }
+
+ return count;
+ },
+ clearFilterText: function(get) {
+ let count = get('filterCount');
+ let fieldMsg = '';
+ if (count > 1) {
+ fieldMsg = ` (${count} ${gettext('Fields')})`;
+ } else if (count > 0) {
+ fieldMsg = ` (1 ${gettext('Field')})`;
+ }
+ return gettext('Clear Filter') + fieldMsg;
+ },
},
stores: {
@@ -186,6 +231,16 @@ Ext.define('Proxmox.node.Tasks', {
handler: 'reload',
},
'->',
+ {
+ xtype: 'button',
+ bind: {
+ text: '{clearFilterText}',
+ disabled: '{!filterCount}',
+ },
+ text: gettext('Clear Filter'),
+ enabled: false,
+ handler: 'clearFilter',
+ },
{
xtype: 'button',
enableToggle: true,
--
2.30.2
next prev parent reply other threads:[~2021-07-05 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 14:33 [pve-devel] [PATCH widget-toolkit 1/4] node/Task: remove leftover 'datastore' reference Dominik Csapak
2021-07-05 14:34 ` [pve-devel] [PATCH widget-toolkit 2/4] node/Tasks: deselect entries when filter changes Dominik Csapak
2021-07-05 14:34 ` [pve-devel] [PATCH widget-toolkit 3/4] node/Task: show errors on store load Dominik Csapak
2021-07-05 14:34 ` Dominik Csapak [this message]
2021-07-05 14:45 ` [pve-devel] applied: [PATCH widget-toolkit 1/4] node/Task: remove leftover 'datastore' reference Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705143402.2362828-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox