[pve-devel] [PATCH widget-toolkit 3/4] node/Task: show errors on store load

[Dominik Csapak <d.csapak@proxmox.com>]

since we use a buffered store on a grid, we cannot use our
normal monStoreErrors from Utils (The store on the grid is a memorystore
without our 'proxmox' proxy, and the store in the viewmodel is not
initialized yet in the init)

simply set the mask in the already existing 'updateLayout' function
which is exactly the right place for the buffered store load

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
i did not find suitable way to reuse the monStoreErrors function,
since it seems that the store from the viewmodel gets instantiated
late in the component creation, and using something like 'afterrender'
will probably also be wrongs, since the loadmask may already be there...

 src/node/Tasks.js | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/node/Tasks.js b/src/node/Tasks.js
index d93111b..dfe93dc 100644
--- a/src/node/Tasks.js
+++ b/src/node/Tasks.js
@@ -36,12 +36,18 @@ Ext.define('Proxmox.node.Tasks', {
 	    }).show();
 	},
 
-	updateLayout: function() {
+	updateLayout: function(store, records, success, operation) {
 	    let me = this;
+	    let view = me.getView().getView(); // the table view, not the whole grid
+	    Proxmox.Utils.setErrorMask(view, false);
 	    // update the scrollbar on every store load since the total count might be different.
 	    // the buffered grid plugin does this only on (user) scrolling itself and even reduces
 	    // the scrollheight again when scrolling up
 	    me.getView().updateLayout();
+
+	    if (!success) {
+		Proxmox.Utils.setErrorMask(view, Proxmox.Utils.getResponseErrorMessage(operation.getError()));
+	    }
 	},
 
 	refresh: function() {
@@ -83,14 +89,8 @@ Ext.define('Proxmox.node.Tasks', {
 	    let vm = me.getViewModel();
 	    vm.set('showFilter', pressed);
 	},
-
-	init: function(view) {
-	    let me = this;
-	    Proxmox.Utils.monStoreErrors(view, view.getStore(), true);
-	},
     },
 
-
     listeners: {
 	itemdblclick: 'showTaskLog',
     },
-- 
2.30.2