From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 2/4] node/Tasks: deselect entries when filter changes
Date: Mon, 5 Jul 2021 16:34:00 +0200 [thread overview]
Message-ID: <20210705143402.2362828-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210705143402.2362828-1-d.csapak@proxmox.com>
since we use a remotefilter on a bufferedstore, the only event where
we can check if the selected element is still there is the 'refresh'
event. Simply deselect if the seleceted element is not in the store
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/node/Tasks.js | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/src/node/Tasks.js b/src/node/Tasks.js
index 0c5b79a..d93111b 100644
--- a/src/node/Tasks.js
+++ b/src/node/Tasks.js
@@ -44,6 +44,20 @@ Ext.define('Proxmox.node.Tasks', {
me.getView().updateLayout();
},
+ refresh: function() {
+ let me = this;
+ let view = me.getView();
+
+ let selection = view.getSelection();
+ let store = me.getViewModel().get('bufferedstore');
+ if (selection && selection.length > 0) {
+ // deselect if selection is not there anymore
+ if (!store.contains(selection[0])) {
+ view.setSelection(undefined);
+ }
+ }
+ },
+
sinceChange: function(field, newval) {
let me = this;
let vm = me.getViewModel();
@@ -144,6 +158,7 @@ Ext.define('Proxmox.node.Tasks', {
},
listeners: {
prefetch: 'updateLayout',
+ refresh: 'refresh',
},
},
},
--
2.30.2
next prev parent reply other threads:[~2021-07-05 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 14:33 [pve-devel] [PATCH widget-toolkit 1/4] node/Task: remove leftover 'datastore' reference Dominik Csapak
2021-07-05 14:34 ` Dominik Csapak [this message]
2021-07-05 14:34 ` [pve-devel] [PATCH widget-toolkit 3/4] node/Task: show errors on store load Dominik Csapak
2021-07-05 14:34 ` [pve-devel] [PATCH widget-toolkit 4/4] node/Tasks: add 'clear filter' button Dominik Csapak
2021-07-05 14:45 ` [pve-devel] applied: [PATCH widget-toolkit 1/4] node/Task: remove leftover 'datastore' reference Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705143402.2362828-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox