[pve-devel] [PATCH proxmox-apt] tests: parse and write the result again

[pve-devel] [PATCH proxmox-apt] tests: parse and write the result again

[Fabian Ebner]

A cheap way to "double" the number of test cases.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 tests/repositories.rs | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/repositories.rs b/tests/repositories.rs
index 289bbe4..67b0255 100644
--- a/tests/repositories.rs
+++ b/tests/repositories.rs
@@ -11,8 +11,15 @@ use proxmox_apt::repositories::{
 
 #[test]
 fn test_parse_write() -> Result<(), Error> {
+    test_parse_write_dir("sources.list.d")?;
+    test_parse_write_dir("sources.list.d.expected")?; // check if it's idempotent
+
+    Ok(())
+}
+
+fn test_parse_write_dir(read_dir: &str) -> Result<(), Error> {
     let test_dir = std::env::current_dir()?.join("tests");
-    let read_dir = test_dir.join("sources.list.d");
+    let read_dir = test_dir.join(read_dir);
     let write_dir = test_dir.join("sources.list.d.actual");
     let expected_dir = test_dir.join("sources.list.d.expected");
 
-- 
2.30.2

[pve-devel] applied: [PATCH proxmox-apt] tests: parse and write the result again

[Thomas Lamprecht]

On 02.07.21 11:31, Fabian Ebner wrote:
> A cheap way to "double" the number of test cases.

"doubling" is a bit of a stretch but I get where you're coming from ;-) 
Parser self-tests are still always good to do additionally, ensuring a
stable serialization and de-serialization.

> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  tests/repositories.rs | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
>

applied, thanks!