public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-apt] Support quoted parsing for .list format
Date: Thu,  1 Jul 2021 15:46:32 +0200	[thread overview]
Message-ID: <20210701134634.130628-1-f.ebner@proxmox.com> (raw)

First patch is just replacing the unicode back-tick that caused
problems down the line. Not related to the second patch.

Second patch makes the .lists files parser aware of quoting, which
fixes parsing CD ROM and file:// repositories with spaces, and in
general makes the parser behave more like APT.

Fabian Ebner (2):
  avoid backtick unicode symbol in string
  support quote-word parsing for one-line format

 src/repositories/file/list_parser.rs      | 143 +++++++++++++++++-----
 src/repositories/repository.rs            |  58 ++++++++-
 src/repositories/standard.rs              |   2 +-
 tests/sources.list.d.expected/cdroms.list |  10 ++
 tests/sources.list.d.expected/files.list  |   4 +
 tests/sources.list.d/cdroms.list          |   7 ++
 tests/sources.list.d/files.list           |   2 +
 7 files changed, 187 insertions(+), 39 deletions(-)
 create mode 100644 tests/sources.list.d.expected/cdroms.list
 create mode 100644 tests/sources.list.d.expected/files.list
 create mode 100644 tests/sources.list.d/cdroms.list
 create mode 100644 tests/sources.list.d/files.list

-- 
2.30.2





             reply	other threads:[~2021-07-01 13:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01 13:46 Fabian Ebner [this message]
2021-07-01 13:46 ` [pve-devel] [PATCH proxmox-apt 1/2] avoid backtick unicode symbol in string Fabian Ebner
2021-07-01 13:46 ` [pve-devel] [PATCH proxmox-apt 2/2] support quote-word parsing for one-line format Fabian Ebner
2021-07-01 16:30 ` [pve-devel] applied: [PATCH proxmox-apt] Support quoted parsing for .list format Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210701134634.130628-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal