From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/2] pve6to7: drop PASS for Luminous -> Nautilus check
Date: Thu, 1 Jul 2021 09:58:57 +0200 [thread overview]
Message-ID: <20210701075857.3871664-2-f.gruenbichler@proxmox.com> (raw)
In-Reply-To: <20210701075857.3871664-1-f.gruenbichler@proxmox.com>
this should pass on pretty much every system running hyper converged
Ceph on PVE 6.x ..
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
Notes:
there are for sure more things to adapt w.r.t. Ceph..
PVE/CLI/pve6to7.pm | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/PVE/CLI/pve6to7.pm b/PVE/CLI/pve6to7.pm
index 899ef6c6..5208c170 100644
--- a/PVE/CLI/pve6to7.pm
+++ b/PVE/CLI/pve6to7.pm
@@ -414,9 +414,7 @@ sub check_ceph {
if (!$osd_flags) {
log_fail("unable to get Ceph OSD flags!");
} else {
- if ($osd_flags =~ m/recovery_deletes/ && $osd_flags =~ m/purged_snapdirs/) {
- log_pass("all PGs have been scrubbed at least once while running Ceph Luminous."); # FIXME: remove?
- } else {
+ if (!($osd_flags =~ m/recovery_deletes/ && $osd_flags =~ m/purged_snapdirs/)) {
log_fail("missing 'recovery_deletes' and/or 'purged_snapdirs' flag, scrub of all PGs required before upgrading to Nautilus!");
}
}
--
2.30.2
next prev parent reply other threads:[~2021-07-01 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 7:58 [pve-devel] [PATCH manager 1/2] pve6to7: reduce number of cluster PASS statements Fabian Grünbichler
2021-07-01 7:58 ` Fabian Grünbichler [this message]
2021-07-02 9:49 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210701075857.3871664-2-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox