From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: panel/GuestStatusView: readd necessary xtypes
Date: Thu, 24 Jun 2021 17:11:39 +0200 [thread overview]
Message-ID: <20210624151139.23052-1-d.csapak@proxmox.com> (raw)
currently, cbind only applies properties on objects which have
an 'xtype' property.
commit 38e6634a8fe8c11ec23e555ce55bc1972ccb5ea1
removed those, thinking the xtype in the 'defaults' is enough
add them back, noting that cbind does need it, to prevent removal
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
we should probably cherry-pick it into stable-6 as well
www/manager6/panel/GuestStatusView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js
index 8db1f492..d59476c1 100644
--- a/www/manager6/panel/GuestStatusView.js
+++ b/www/manager6/panel/GuestStatusView.js
@@ -53,6 +53,7 @@ Ext.define('PVE.panel.GuestStatusView', {
itemId: 'node',
iconCls: 'fa fa-building fa-fw',
title: gettext('Node'),
+ xtype: 'pmxInfoWidget', // necessary for cbind to apply
cbind: {
text: '{pveSelNode.data.node}',
},
@@ -86,6 +87,7 @@ Ext.define('PVE.panel.GuestStatusView', {
title: gettext('SWAP usage'),
valueField: 'swap',
maxField: 'maxswap',
+ xtype: 'pmxInfoWidget', // necessary for cbind to apply
cbind: {
hidden: '{isQemu}',
disabled: '{isQemu}',
--
2.20.1
next reply other threads:[~2021-06-24 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 15:11 Dominik Csapak [this message]
2021-06-25 7:14 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624151139.23052-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox