[pve-devel] [PATCH installer] zfs: allow RAID0 with different-sized disks

[pve-devel] [PATCH installer] zfs: allow RAID0 with different-sized disks

[Stefan Reiter]

zfs_mirror_size_check is already called in get_zfs_raid_setup when
necessary, so don't call it unconditionally, as this will cause a
false-positive error on RAID0 devices (where size mismatches are fine).

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
 proxinstall | 2 --
 1 file changed, 2 deletions(-)

diff --git a/proxinstall b/proxinstall
index a6176d2..213486a 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1426,8 +1426,6 @@ sub extract_data {
 		my ($size, $osdev, $efidev) =
 		    partition_bootable_disk($devname, $config_options->{hdsize}, 'BF01');
 
-		zfs_mirror_size_check($disksize, $size) if $disksize;
-
 		push @$bootdevinfo, {
 		    esp => $efidev,
 		    devname => $devname,
-- 
2.30.2

Re: [pve-devel] [PATCH installer] zfs: allow RAID0 with different-sized disks

[Stoiko Ivanov]

Thanks for the patch!

checked the git-log when and how this got introduced in the first place
and it's been like that since zfs raid configuration was introduced...

I think the change makes sense - in addition to the case of RAID0 with
different sizes, it would also prevent RAID10 with the mirror pairs having
different size (2x 15G and 2x 10G in my tests) - which I also can imagine
is a use-case for some users

Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com>

On Thu, 24 Jun 2021 14:30:13 +0200
Stefan Reiter <s.reiter@proxmox.com> wrote:

> zfs_mirror_size_check is already called in get_zfs_raid_setup when
> necessary, so don't call it unconditionally, as this will cause a
> false-positive error on RAID0 devices (where size mismatches are fine).



> 
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>  proxinstall | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/proxinstall b/proxinstall
> index a6176d2..213486a 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -1426,8 +1426,6 @@ sub extract_data {
>  		my ($size, $osdev, $efidev) =
>  		    partition_bootable_disk($devname, $config_options->{hdsize}, 'BF01');
>  
> -		zfs_mirror_size_check($disksize, $size) if $disksize;
> -
>  		push @$bootdevinfo, {
>  		    esp => $efidev,
>  		    devname => $devname,

[pve-devel] applied: [PATCH installer] zfs: allow RAID0 with different-sized disks

[Thomas Lamprecht]

On 24.06.21 14:30, Stefan Reiter wrote:
> zfs_mirror_size_check is already called in get_zfs_raid_setup when
> necessary, so don't call it unconditionally, as this will cause a
> false-positive error on RAID0 devices (where size mismatches are fine).
> 
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>  proxinstall | 2 --
>  1 file changed, 2 deletions(-)
> 
>

applied, thanks!