From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: fix Guest Summary Notes height
Date: Fri, 18 Jun 2021 13:34:09 +0200 [thread overview]
Message-ID: <20210618113409.32548-1-d.csapak@proxmox.com> (raw)
fixes 'infinite' height of the guest notes, by setting the height on the
container a level up
the notes view itself is already scrollable, so if it is too large,
there'll be a scrollbar
this does not change anything for templates, as there we show nothing
under the notes and thus there the infinite height is ok
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
should apply to stable-6 too if we want that
www/manager6/panel/GuestStatusView.js | 2 --
www/manager6/panel/GuestSummary.js | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js
index 5929d9bf..8db1f492 100644
--- a/www/manager6/panel/GuestStatusView.js
+++ b/www/manager6/panel/GuestStatusView.js
@@ -3,8 +3,6 @@ Ext.define('PVE.panel.GuestStatusView', {
alias: 'widget.pveGuestStatusView',
mixins: ['Proxmox.Mixin.CBind'],
- height: 300,
-
cbindData: function(initialConfig) {
var me = this;
return {
diff --git a/www/manager6/panel/GuestSummary.js b/www/manager6/panel/GuestSummary.js
index 7061b1a4..82cc7a7f 100644
--- a/www/manager6/panel/GuestSummary.js
+++ b/www/manager6/panel/GuestSummary.js
@@ -54,6 +54,7 @@ Ext.define('PVE.qemu.Summary', {
items = [
{
xtype: 'container',
+ height: 300,
layout: {
type: 'hbox',
align: 'stretch',
--
2.20.1
next reply other threads:[~2021-06-18 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 11:34 Dominik Csapak [this message]
2021-06-18 11:38 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618113409.32548-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox