public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH zfsonlinux 16/16] do not restart zfs-volume-wait.service
Date: Thu, 17 Jun 2021 15:52:23 +0200	[thread overview]
Message-ID: <20210617135223.23472-17-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20210617135223.23472-1-s.ivanov@proxmox.com>

in postinst. During the transition from ZFS 0.8.x to 2.0.0 zvol_wait,
which is called by zfs-volume-wait.service was changed to also output
the redacted_snap property of the datasets.
This property does not exist if the kernelmodule is still 0.8.x,
causing an error to be printed to the journal.

Since the starting the service should not change anything in a running
system (the zvol links are already present), simply don't restart it
on upgrades

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 debian/rules | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/debian/rules b/debian/rules
index e5166882..9c14e1bb 100755
--- a/debian/rules
+++ b/debian/rules
@@ -107,6 +107,10 @@ override_dh_install:
 override_dh_missing:
 	dh_missing --fail-missing
 
+override_dh_installsystemd:
+	dh_installsystemd --no-stop-on-upgrade -X zfs-zed.service
+	dh_installsystemd --name zfs-zed
+
 override_dh_installdocs:
 	dh_installdocs
 ifeq (,$(findstring nodoc, $(DEB_BUILD_OPTIONS)))
-- 
2.20.1





  parent reply	other threads:[~2021-06-17 13:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 13:52 [pve-devel] [PATCH zfsonlinux 00/16] sync buildsys with debian-upstream Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 01/16] buildsys: unify '{' and '(' in Makefile Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 02/16] buildsys: add all packages to make variable and sort Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 03/16] Reflect libssl requirement of libzfs Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 04/16] Elaborate the functionality of ZED in long description. (Closes: #979414) Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 05/16] buildsys: switch to automatic debug packages Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 06/16] Bump debhelper compat level to 12 Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 07/16] compat 12 automatically adds initramfs trigger Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 08/16] Bump Standards-Version to 4.5.1 (no changes) Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 09/16] Adjust zed.d symlink-preservation Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 10/16] Remove /etc/zfs/zed.d on purge Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 11/16] sync scrub and trim cronjobs with debian upstream Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 12/16] update lintian-overrides Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 13/16] drop unused lintian overrides Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 14/16] add symbol files for library packages Stoiko Ivanov
2021-06-17 13:52 ` [pve-devel] [PATCH zfsonlinux 15/16] update libzpool symbols Stoiko Ivanov
2021-06-17 13:52 ` Stoiko Ivanov [this message]
2021-06-18 13:44 ` [pve-devel] applied: [PATCH zfsonlinux 00/16] sync buildsys with debian-upstream Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210617135223.23472-17-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal