Re: [pve-devel] [PATCH v4 container 0/2] post_clone hook for containers

[Oguz Bektas <o.bektas@proxmox.com>]

On Wed, Jun 16, 2021 at 03:48:42PM +0200, Thomas Lamprecht wrote:
> On 16.06.21 15:24, Oguz Bektas wrote:
> > fixes #3443 by implementing post_clone_hook for containers (which at the
> > moment only generates a unique /etc/machine-id for the cloned
> > container). this can be reused later for other things we want to do post
> > clone.
> > 
> 
> what are the changes since v3? I did not found any note here nor in the actual
> patches.

oops. sorry!

v3->v4:
* call generic post_clone_hook in setup code instead of directly calling
clear_machine_id in clone_vm API
* improve config locking in clone_vm API (don't write to config file
without checking/obtaining lock on it)
* clone firewall config _inside_ worker instead of _before_ worker
* fixed minor typo in error message for bind mounts

> 
> > 
> > 
> > Oguz Bektas (2):
> >   setup: add post_clone_hook for containers
> >   run post_clone_hook in clone_vm
> > 
> >  src/PVE/API2/LXC.pm       | 37 ++++++++++++++++++++++++++++++-------
> >  src/PVE/LXC/Setup.pm      | 12 ++++++++++++
> >  src/PVE/LXC/Setup/Base.pm | 31 +++++++++++++++++++++++++++++++
> >  3 files changed, 73 insertions(+), 7 deletions(-)
> > 
>