* [pve-devel] [PATCH v2 storage] Revert "workaround zfs create -V error for unaligned sizes"
@ 2021-06-11 10:27 Aaron Lauterer
0 siblings, 0 replies; only message in thread
From: Aaron Lauterer @ 2021-06-11 10:27 UTC (permalink / raw)
To: pve-devel
https://github.com/zfsonlinux/zfs/issues/8541 is solved and part of
openzfs 2.0 with [0]. Since we ship only ZFS 2.0 with PVE 7 we should be
okay to remove our workaround
[0] https://github.com/openzfs/zfs/commit/47c9299fcc9e5fb91d0b1636bfacc03bd3e98439
This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15.
Tested-by: Fabian Ebner <f.ebner@proxmox.com>
---
removed whitespace in the newline (hope thats the way you meant @thomas)
and added fabis T-b tag.
PVE/Storage/ZFSPoolPlugin.pm | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm
index 2e2abe3..f719f42 100644
--- a/PVE/Storage/ZFSPoolPlugin.pm
+++ b/PVE/Storage/ZFSPoolPlugin.pm
@@ -313,12 +313,7 @@ sub zfs_get_pool_stats {
sub zfs_create_zvol {
my ($class, $scfg, $zvol, $size) = @_;
-
- # always align size to 1M as workaround until
- # https://github.com/zfsonlinux/zfs/issues/8541 is solved
- my $padding = (1024 - $size % 1024) % 1024;
- $size = $size + $padding;
-
+
my $cmd = ['create'];
push @$cmd, '-s' if $scfg->{sparse};
--
2.30.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-11 10:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-11 10:27 [pve-devel] [PATCH v2 storage] Revert "workaround zfs create -V error for unaligned sizes" Aaron Lauterer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox