From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v6 manager 7/7] fix #1710: ui: storage: add download from url button
Date: Fri, 11 Jun 2021 09:27:46 +0200 [thread overview]
Message-ID: <20210611072746.GA40697@mala.proxmox.com> (raw)
In-Reply-To: <20210517080318.51405-8-l.stechauner@proxmox.com>
On Mon, May 17, 2021 at 10:03:18AM +0200, Lorenz Stechauner wrote:
> + iso: [ > + 'application/octet-stream',
> + 'application/x-iso9660-image',
> + 'application/x-ima',
When I try do download a Proxmox VE image I get type x-cd-image.
https://www.proxmox.com/en/downloads?task=callelement&format=raw&item_id=589&element=f85c494b-2b32-4109-b8c1-083cca2b7db6&method=download&args[0]=b9d30b3515e7a12dff5619ff1e1843be
Then the download button should not be deactivated.
> + advancedColumn1: [
> + {
> + xtype: 'textfield',
> + name: 'checksum',
> + fieldLabel: gettext('Checksum'),
> + allowBlank: true,
> + disabled: true,
> + emptyText: gettext('none'),
> + id: 'downloadUrlChecksum',
> + },
> + {
> + xtype: 'pveHashAlgorithmSelector',
> + name: 'checksum-algorithm',
> + fieldLabel: gettext('Hash algorithm'),
> + allowBlank: true,
> + hasNoneOption: true,
> + value: '__default__',
> + listeners: {
> + change: 'hashChange',
> + },
> + },
An algorithm must be selected before entering something into the textfield.
Therefore, I'd place the algorithm selector above/before the textfield.
> + ],
> + advancedColumn2: [
> + {
> + xtype: 'textfield',
> + fieldLabel: gettext('MIME type'),
> + name: 'mimetype',
> + disabled: true,
> + editable: false,
Non-editable might be good in general, but I cannot download the PVE image with
(unsupported) type x-cd-image because it will remain invalid forever.
> + emptyText: gettext('unknown'),
> + listeners: {
> + change: 'typeChange',
> + },
> + },
> + {
> + xtype: 'proxmoxcheckbox',
> + name: 'verify-certificates',
> + fieldLabel: gettext('Verify certificates'),
> + uncheckedValue: 0,
> + checked: true,
> + listeners: {
> + change: 'urlChange',
> + },
> + },
> + ],
> + },
> + ],
> +
Downloading a Debian image and verifying with SHA512 worked for me
https://cdimage.debian.org/debian-cd/current/amd64/iso-dvd/debian-10.9.0-amd64-DVD-1.iso
Tested-by: Dominic Jäger <d.jaeger@proxmox.com>
next prev parent reply other threads:[~2021-06-11 7:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 8:03 [pve-devel] [PATCH-SERIES v6 manager/common/storage] fix #1710: " Lorenz Stechauner
2021-05-17 8:03 ` [pve-devel] [PATCH v6 manager 1/7] api: nodes: add query_url_metadata method Lorenz Stechauner
2021-06-11 7:27 ` Dominic Jäger
2021-05-17 8:03 ` [pve-devel] [PATCH v6 common 2/7] tools: add download_file_from_url Lorenz Stechauner
2021-05-17 8:03 ` [pve-devel] [PATCH v6 manager 3/7] api: nodes: refactor aplinfo to use common download function Lorenz Stechauner
2021-05-17 8:03 ` [pve-devel] [PATCH v6 storage 4/7] status: add download_url method Lorenz Stechauner
2021-05-17 8:03 ` [pve-devel] [PATCH v6 manager 5/7] ui: add HashAlgorithmSelector Lorenz Stechauner
2021-05-17 8:03 ` [pve-devel] [PATCH v6 manager 6/7] ui: Utils: change download task format Lorenz Stechauner
2021-05-17 8:03 ` [pve-devel] [PATCH v6 manager 7/7] fix #1710: ui: storage: add download from url button Lorenz Stechauner
2021-06-11 7:27 ` Dominic Jäger [this message]
2021-06-11 8:30 ` Lorenz Stechauner
2021-06-09 6:50 ` [pve-devel] [PATCH-SERIES v6 manager/common/storage] fix #1710: " Lorenz Stechauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611072746.GA40697@mala.proxmox.com \
--to=d.jaeger@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox