public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Reiter <s.reiter@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 2/2] enable io-uring support
Date: Mon,  7 Jun 2021 13:48:50 +0200	[thread overview]
Message-ID: <20210607114850.964814-3-s.reiter@proxmox.com> (raw)
In-Reply-To: <20210607114850.964814-1-s.reiter@proxmox.com>

Note that the value in this enum directly represents the value passed to
QEMU, so we need to use the underscore.

Off by default, updated QEMU required, but no compatibility issues, as
this is a new value that wasn't valid before, and setting it is the
users choice.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---

We probably want this in the GUI as well, there isn't even an option for 'aio'
in general atm. Thought I'd send it out without just for testing and getting the
conversation going.

On a side note, I feel like exposing an option called "threads" when we already
have "iothread" as well might get confusing.

Also, if it works well, we could probably make this the default later (probably
not a great idea for 7.0 though?).

 PVE/QemuServer/Drive.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
index 146a4ab..82a6bfe 100644
--- a/PVE/QemuServer/Drive.pm
+++ b/PVE/QemuServer/Drive.pm
@@ -116,7 +116,7 @@ my %drivedesc_base = (
     },
     aio => {
 	type => 'string',
-	enum => [qw(native threads)],
+	enum => [qw(native threads io_uring)],
 	description => 'AIO type to use.',
 	optional => 1,
     },
-- 
2.30.2





  parent reply	other threads:[~2021-06-07 11:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 11:48 [pve-devel] [PATCH 0/2] Enable io-uring support in QEMU Stefan Reiter
2021-06-07 11:48 ` [pve-devel] [PATCH pve-qemu 1/2] enable io-uring support in QEMU builds Stefan Reiter
2021-06-21  7:57   ` [pve-devel] applied: " Thomas Lamprecht
2021-06-07 11:48 ` Stefan Reiter [this message]
2021-06-21  8:00   ` [pve-devel] [PATCH qemu-server 2/2] enable io-uring support Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210607114850.964814-3-s.reiter@proxmox.com \
    --to=s.reiter@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal