[pve-devel] [PATCH manager] ui: ceph/Pools: defuse min_size warning

[pve-devel] [PATCH manager] ui: ceph/Pools: defuse min_size warning

[Dominik Csapak]

we should not warn for the ceph built-in default warnings for min_size
having the min_size half of the size (rounded up) is ok and
even the default for ceph

since there seems to be no 'quorum based' pg inconsistency recovery[0],
only a copy from the authoritative osd, there is nothing wrong
with setting that.

0: https://docs.ceph.com/en/latest/rados/operations/pg-repair/

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/ceph/Pool.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index 41c08c39..41df216e 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -28,7 +28,7 @@ Ext.define('PVE.CephPoolInputPanel', {
 	    allowBlank: false,
 	    listeners: {
 		change: function(field, val) {
-		    let size = Math.round((val + 1) / 2);
+		    let size = Math.round(val / 2);
 		    if (size > 1) {
 			field.up('inputpanel').down('field[name=min_size]').setValue(size);
 		    }
@@ -82,7 +82,7 @@ Ext.define('PVE.CephPoolInputPanel', {
 		    let panel = field.up('inputpanel');
 		    let size = panel.down('field[name=size]').getValue();
 
-		    let showWarning = minSize <= size / 2 && minSize !== size;
+		    let showWarning = minSize < (size / 2) && minSize !== size;
 
 		    let fieldLabel = gettext('Min. Size');
 		    if (showWarning) {
@@ -97,7 +97,7 @@ Ext.define('PVE.CephPoolInputPanel', {
 	    xtype: 'displayfield',
 	    name: 'min_size-warning',
 	    userCls: 'pmx-hint',
-	    value: gettext('min_size <= size/2 can lead to data loss, incomplete PGs or unfound objects.'),
+	    value: gettext('min_size < size/2 can lead to data loss, incomplete PGs or unfound objects.'),
 	    hidden: true,
 	},
 	{
-- 
2.20.1

Re: [pve-devel] [PATCH manager] ui: ceph/Pools: defuse min_size warning

[Dominik Csapak]

argh a typo slipped through...

On 6/7/21 12:31, Dominik Csapak wrote:
> we should not warn for the ceph built-in default warnings for min_size

the word 'warnings' should not be there...

> having the min_size half of the size (rounded up) is ok and
> even the default for ceph
> 
> since there seems to be no 'quorum based' pg inconsistency recovery[0],
> only a copy from the authoritative osd, there is nothing wrong
> with setting that.
> 
> 0: https://docs.ceph.com/en/latest/rados/operations/pg-repair/
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>   www/manager6/ceph/Pool.js | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
> index 41c08c39..41df216e 100644
> --- a/www/manager6/ceph/Pool.js
> +++ b/www/manager6/ceph/Pool.js
> @@ -28,7 +28,7 @@ Ext.define('PVE.CephPoolInputPanel', {
>   	    allowBlank: false,
>   	    listeners: {
>   		change: function(field, val) {
> -		    let size = Math.round((val + 1) / 2);
> +		    let size = Math.round(val / 2);
>   		    if (size > 1) {
>   			field.up('inputpanel').down('field[name=min_size]').setValue(size);
>   		    }
> @@ -82,7 +82,7 @@ Ext.define('PVE.CephPoolInputPanel', {
>   		    let panel = field.up('inputpanel');
>   		    let size = panel.down('field[name=size]').getValue();
>   
> -		    let showWarning = minSize <= size / 2 && minSize !== size;
> +		    let showWarning = minSize < (size / 2) && minSize !== size;
>   
>   		    let fieldLabel = gettext('Min. Size');
>   		    if (showWarning) {
> @@ -97,7 +97,7 @@ Ext.define('PVE.CephPoolInputPanel', {
>   	    xtype: 'displayfield',
>   	    name: 'min_size-warning',
>   	    userCls: 'pmx-hint',
> -	    value: gettext('min_size <= size/2 can lead to data loss, incomplete PGs or unfound objects.'),
> +	    value: gettext('min_size < size/2 can lead to data loss, incomplete PGs or unfound objects.'),
>   	    hidden: true,
>   	},
>   	{
> 

[pve-devel] applied: [PATCH manager] ui: ceph/Pools: defuse min_size warning

[Thomas Lamprecht]

On 07.06.21 12:31, Dominik Csapak wrote:
> we should not warn for the ceph built-in default warnings for min_size
> having the min_size half of the size (rounded up) is ok and
> even the default for ceph
> 
> since there seems to be no 'quorum based' pg inconsistency recovery[0],
> only a copy from the authoritative osd, there is nothing wrong
> with setting that.
> 
> 0: https://docs.ceph.com/en/latest/rados/operations/pg-repair/
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/ceph/Pool.js | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
>

applied, with slightly reworded commit message, thanks!