public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH-SERIES] Some breaking API changes/cleanups
@ 2021-06-04 13:49 Fabian Ebner
  2021-06-04 13:49 ` [pve-devel] [PATCH guest-common 1/2] vzdump: remove deprecated size parameter Fabian Ebner
                   ` (22 more replies)
  0 siblings, 23 replies; 32+ messages in thread
From: Fabian Ebner @ 2021-06-04 13:49 UTC (permalink / raw)
  To: pve-devel


Of course all of the changes need to be recorded in the release notes.
Should I do so now or wait until the changes are actually applied?

Dependencies are noted on individual patches, most should apply independently.

There's still quite a few outstanding, but I feel like somebody with more
experience/context would be better suited to address them. I can go for another
round though if there are not enough volunteers ;)


pve-access-control:
src/PVE/Auth/AD.pm
30:         description => "Use secure LDAPS protocol. DEPRECATED: use 'mode' instead.",
src/PVE/Auth/LDAP.pm
390:    # FIXME: remove fallback with 7.0 by doing a rename on upgrade from 6.x

src/PVE/AccessControl.pm
299:    # FIXME: remove with PVE 7 and/or refactor all into PVE::Ticket ?

pve-common:
src/PVE/Ticket.pm
38:         # detected sha1 csrf token from older proxy, fallback. FIXME: remove with 7.0

pve-cluster:
quite a few // FIXME: remove openvz stuff for 7.x

pve-storage:
PVE/Storage/CephFSPlugin.pm
41:# FIXME: remove in PVE 7.0 where systemd is recent enough to not have those
# local-fs/remote-fs dependency cycles generated for _netdev mounts...


Would be glad if somebody experienced in those areas could look at them.



data/PVE/DataCenterConfig.pm has a few workarounds for deprecated options

pve-container:
src/PVE/LXC/Config.pm
652:    # Deprecated (removed with lxc 3.0):

src/PVE/LXC.pm
2178:   # FIXME: remove the 'id_map' variant when lxc-3.0 arrives


There might still be lxc/datacenter configs with the old options around?
Do we want to warn/replace as part of the pve6to7 script or just keep
the compat code longer?



pve-manager:
PVE/Ceph/Services.pm
54:     # FIXME: remove with 7.0 - for backward compat only

PVE/API2/Cluster/Ceph.pm
78:         # FIXME: remove with 7.0 depreacated by structured 'versions'


Front-end still expects the metadata.version to be present. Might not be hard to
adapt, but I didn't have the context to immediately know what's the right thing
to do. Can look at it if nobody else wants to.



pve-storage:
PVE/Storage.pm
966:    # FIXME PVE 7.0: only scan storages with the correct content types


From an off-list discussion with Fabian G: We currently still need this behavior
to pick up disks from storages with a misconfigured content types. Meaning that
we need to require content type 'images' to be set first and warn people with
misconfigured storages as part of pve6to7. We could even go further and not pick
up unreferenced disks at all, but should expose rescan in the UI and make a
rescan as part of pve6to7. I will look at this in a separate series.



pve-guest-common:

Fabian Ebner (2):
  vzdump: remove deprecated size parameter
  vzdump: defaults: keep all backups by default for 7.0

 src/PVE/VZDump/Common.pm | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)


pve-container:

Fabian Ebner (1):
  migrate: remove deprecated force parameter

 src/PVE/API2/LXC.pm    | 6 ------
 src/PVE/LXC/Migrate.pm | 8 +-------
 2 files changed, 1 insertion(+), 13 deletions(-)


qemu-server:

Fabian Ebner (3):
  Revert "revert spice_ticket prefix change in 7827de4"
  scan volids: remove superfluous parameter
  vm destroy: do not remove unreferenced disks by default

 PVE/API2/Qemu.pm   | 5 ++---
 PVE/QemuMigrate.pm | 5 ++---
 PVE/QemuServer.pm  | 7 +++----
 3 files changed, 7 insertions(+), 10 deletions(-)


pve-storage:

Fabian Ebner (3):
  postinst: move cifs credential files into subdirectory upon update
  update reminder to remove maxfiles
  api: get rid of moved 'usb' call

 PVE/API2/Storage/Scan.pm  | 45 ---------------------------------------
 PVE/Storage.pm            |  2 +-
 PVE/Storage/CIFSPlugin.pm |  3 ---
 debian/postinst           | 30 ++++++++++++++++++++++++++
 4 files changed, 31 insertions(+), 49 deletions(-)
 create mode 100644 debian/postinst


novnc-pve:

Fabian Ebner (1):
  avoid passing deprecated 'upgrade' parameter

 ...passing-deprecated-upgrade-parameter.patch | 24 +++++++++++++++++++
 debian/patches/series                         |  1 +
 2 files changed, 25 insertions(+)
 create mode 100644 debian/patches/0014-avoid-passing-deprecated-upgrade-parameter.patch

pve-manager:

Fabian Ebner (12):
  vzdump: remove deprecated size parameter
  configs: vzdump: use prune-backups instead of the deprecated maxfiles
  test: vzdump: adapt to new default
  Revert "VZDump: add TARFILE to environment for hookscripts"
  api: nodes: remove deprecated upgrade parameter for xtermjs
  api: nodes: remove deprecated upgrade parameter for spiceshell
  api: nodes: remove deprecated upgrade parameter for vncshell
  api: move cpu path into qemu/capabilities
  api: ceph: remove obsoleted disks call
  api: ceph: remove moved 'flags' calls
  api: ceph: osd: create: rename size parameters
  cli: pveceph: remove outdated comment

 PVE/API2/Capabilities.pm              |   6 +
 PVE/API2/Ceph.pm                      | 178 --------------------------
 PVE/API2/Ceph/OSD.pm                  |   8 +-
 PVE/API2/Nodes.pm                     |  48 ++-----
 PVE/API2/VZDump.pm                    |   2 -
 PVE/CLI/pveceph.pm                    |   1 -
 PVE/VZDump.pm                         |   6 -
 configs/vzdump.conf                   |   3 +-
 test/vzdump_new_test.pl               |   8 +-
 www/manager6/ceph/OSD.js              |   8 +-
 www/manager6/form/CPUModelSelector.js |   2 +-
 11 files changed, 27 insertions(+), 243 deletions(-)

-- 
2.30.2





^ permalink raw reply	[flat|nested] 32+ messages in thread

end of thread, other threads:[~2021-06-10  9:36 UTC | newest]

Thread overview: 32+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 13:49 [pve-devel] [PATCH-SERIES] Some breaking API changes/cleanups Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH guest-common 1/2] vzdump: remove deprecated size parameter Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH/RFC guest-common 2/2] vzdump: defaults: keep all backups by default for 7.0 Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH container 1/1] migrate: remove deprecated force parameter Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH qemu-server 1/3] Revert "revert spice_ticket prefix change in 7827de4" Fabian Ebner
2021-06-07  8:27   ` Stefan Reiter
2021-06-04 13:49 ` [pve-devel] [PATCH qemu-server 2/3] scan volids: remove superfluous parameter Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH qemu-server 3/3] vm destroy: do not remove unreferenced disks by default Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH/RFC storage 1/3] postinst: move cifs credential files into subdirectory upon update Fabian Ebner
2021-06-08 13:18   ` Fabian Grünbichler
2021-06-09  6:35     ` Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH storage 2/3] update reminder to remove maxfiles Fabian Ebner
2021-06-08 13:04   ` Fabian Grünbichler
2021-06-08 16:23     ` Thomas Lamprecht
2021-06-09  6:30       ` Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH storage 3/3] api: get rid of moved 'usb' call Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH novnc-pve 1/1] avoid passing deprecated 'upgrade' parameter Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH manager 01/12] vzdump: remove deprecated size parameter Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH manager 02/12] configs: vzdump: use prune-backups instead of the deprecated maxfiles Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH manager 03/12] test: vzdump: adapt to new default Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH manager 04/12] Revert "VZDump: add TARFILE to environment for hookscripts" Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH manager 05/12] api: nodes: remove deprecated upgrade parameter for xtermjs Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH manager 06/12] api: nodes: remove deprecated upgrade parameter for spiceshell Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH manager 07/12] api: nodes: remove deprecated upgrade parameter for vncshell Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH manager 08/12] api: move cpu path into qemu/capabilities Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH manager 09/12] api: ceph: remove obsoleted disks call Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH manager 10/12] api: ceph: remove moved 'flags' calls Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH manager 11/12] api: ceph: osd: create: rename size parameters Fabian Ebner
2021-06-04 13:49 ` [pve-devel] [PATCH manager 12/12] cli: pveceph: remove outdated comment Fabian Ebner
2021-06-09  9:44 ` [pve-devel] applied-partially: [PATCH-SERIES] Some breaking API changes/cleanups Fabian Grünbichler
2021-06-09 11:15   ` Fabian Ebner
2021-06-10  9:36     ` Fabian Grünbichler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal