From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 1/3] Toolkit: move defaultDownloadServerUrl override to panel/RRDChart
Date: Fri, 28 May 2021 14:13:39 +0200 [thread overview]
Message-ID: <20210528121341.16026-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210528121341.16026-1-d.csapak@proxmox.com>
not all users of Toolkit.js have the charts lib loaded, which means
the class does not exist then.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/Toolkit.js | 3 ---
src/panel/RRDChart.js | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/Toolkit.js b/src/Toolkit.js
index 6f1aee9..a08af4e 100644
--- a/src/Toolkit.js
+++ b/src/Toolkit.js
@@ -664,9 +664,6 @@ Ext.define('Proxmox.selection.CheckboxModel', {
},
});
-// override the download server url globally, for privacy reasons
-Ext.draw.Container.prototype.defaultDownloadServerUrl = "-";
-
// stop nulling of properties
Ext.define('Proxmox.Component', {
override: 'Ext.Component',
diff --git a/src/panel/RRDChart.js b/src/panel/RRDChart.js
index 517c45d..d63170e 100644
--- a/src/panel/RRDChart.js
+++ b/src/panel/RRDChart.js
@@ -1,3 +1,6 @@
+// override the download server url globally, for privacy reasons
+Ext.draw.Container.prototype.defaultDownloadServerUrl = "-";
+
Ext.define('Proxmox.chart.axis.segmenter.NumericBase2', {
extend: 'Ext.chart.axis.segmenter.Numeric',
alias: 'segmenter.numericBase2',
--
2.20.1
next prev parent reply other threads:[~2021-05-28 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 12:13 [pve-devel] [PATCH widget-toolkit 0/3] add proxmox-widget-toolkit-dev package Dominik Csapak
2021-05-28 12:13 ` Dominik Csapak [this message]
2021-05-28 12:13 ` [pve-devel] [PATCH widget-toolkit 2/3] add api-viewer source Dominik Csapak
2021-05-28 12:13 ` [pve-devel] [PATCH widget-toolkit 3/3] add proxmox-widget-toolkit-dev package Dominik Csapak
2021-06-02 14:13 ` [pve-devel] applied-series: [PATCH widget-toolkit 0/3] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528121341.16026-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox