[pve-devel] [PATCH qemu-server] api: clone: sort vm disks to keep numbers consistent

[pve-devel] [PATCH qemu-server] api: clone: sort vm disks to keep numbers consistent

[Lorenz Stechauner]

reported by user in forum:
https://forum.proxmox.com/threads/problem-when-copying-template-with-2-discs.89851/

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
---
 PVE/API2/Qemu.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index c56b609..24dba86 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -3157,7 +3157,7 @@ __PACKAGE__->register_method({
 		    my $total_jobs = scalar(keys %{$drives});
 		    my $i = 1;
 
-		    foreach my $opt (keys %$drives) {
+		    foreach my $opt (sort keys %$drives) {
 			my $drive = $drives->{$opt};
 			my $skipcomplete = ($total_jobs != $i); # finish after last drive
 			my $completion = $skipcomplete ? 'skip' : 'complete';
-- 
2.20.1

[pve-devel] applied: [PATCH qemu-server] api: clone: sort vm disks to keep numbers consistent

[Thomas Lamprecht]

On 26.05.21 16:19, Lorenz Stechauner wrote:
> reported by user in forum:
> https://forum.proxmox.com/threads/problem-when-copying-template-with-2-discs.89851/
> 
> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
> ---
>  PVE/API2/Qemu.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!

But note that this sorts drives with different digit-size of the decimal part
also wrong, depnding on POV, e.g., drive1, drive2 and drive10 would sort:

drive1
drive10
drive2

But IMO still lots better that before, especially as they're grouped by bus
type too.