From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 02/11] Toolkit: set download url for draw containers to '-'
Date: Wed, 26 May 2021 10:58:30 +0200 [thread overview]
Message-ID: <20210526085839.9808-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210526085839.9808-1-d.csapak@proxmox.com>
so that there can be no privacy leak, since the default points
to senchas server
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/Toolkit.js | 3 +++
src/panel/GaugeWidget.js | 2 ++
src/panel/RRDChart.js | 3 +++
3 files changed, 8 insertions(+)
diff --git a/src/Toolkit.js b/src/Toolkit.js
index ffbd47a..6787173 100644
--- a/src/Toolkit.js
+++ b/src/Toolkit.js
@@ -659,6 +659,9 @@ Ext.define('Proxmox.selection.CheckboxModel', {
},
});
+// override the download server url globally, for privacy reasons
+Ext.draw.Container.prototype.defaultDownloadServerUrl = "-";
+
// force alert boxes to be rendered with an Error Icon
// since Ext.Msg is an object and not a prototype, we need to override it
// after the framework has been initiated
diff --git a/src/panel/GaugeWidget.js b/src/panel/GaugeWidget.js
index 6cd6b60..0cc2079 100644
--- a/src/panel/GaugeWidget.js
+++ b/src/panel/GaugeWidget.js
@@ -20,6 +20,8 @@ Ext.define('Proxmox.panel.GaugeWidget', {
xtype: 'polar',
height: 120,
border: false,
+ // set to '-' to suppress warning in debug mode
+ downloadServerUrl: '-',
itemId: 'chart',
series: [{
type: 'gauge',
diff --git a/src/panel/RRDChart.js b/src/panel/RRDChart.js
index 41c839e..49b3ad2 100644
--- a/src/panel/RRDChart.js
+++ b/src/panel/RRDChart.js
@@ -61,6 +61,9 @@ Ext.define('Proxmox.widget.RRDChart', {
powerOfTwo: false,
+ // set to empty string to suppress warning in debug mode
+ downloadServerUrl: '-',
+
controller: {
xclass: 'Ext.app.ViewController',
--
2.20.1
next prev parent reply other threads:[~2021-05-26 8:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 8:58 [pve-devel] [PATCH widget-toolkit 00/11] fixes/preparation for extjs7.0 Dominik Csapak
2021-05-26 8:58 ` [pve-devel] [PATCH widget-toolkit 01/11] data/ProxmoxProxy: set responseType to undefined for XMLHTTPRequest Dominik Csapak
2021-05-26 8:58 ` Dominik Csapak [this message]
2021-05-26 8:58 ` [pve-devel] [PATCH widget-toolkit 03/11] Toolkit: set clearPropertiesOnDestroy to false by default Dominik Csapak
2021-05-26 8:58 ` [pve-devel] [PATCH widget-toolkit 04/11] css: add css changes for treelist Dominik Csapak
2021-05-26 8:58 ` [pve-devel] [PATCH widget-toolkit 05/11] panel/RRDChart: fix legend/undoZoom Dominik Csapak
2021-05-26 8:58 ` [pve-devel] [PATCH widget-toolkit 06/11] Toolkit: update overrides for scroll fixes Dominik Csapak
2021-05-26 8:58 ` [pve-devel] [PATCH widget-toolkit 07/11] Toolkit: update focusJump override Dominik Csapak
2021-05-26 8:58 ` [pve-devel] [PATCH widget-toolkit 08/11] Toolkit: remove firefox touchscreen override Dominik Csapak
2021-05-26 8:58 ` [pve-devel] [PATCH widget-toolkit 09/11] Toolkit: remove pie chart fix Dominik Csapak
2021-05-26 8:58 ` [pve-devel] [PATCH widget-toolkit 10/11] Toolkit: remove textarea fix Dominik Csapak
2021-05-26 8:58 ` [pve-devel] [PATCH widget-toolkit 11/11] Toolkit: remove Datepicker fix Dominik Csapak
2021-05-28 8:43 ` [pve-devel] applied: [PATCH widget-toolkit 00/11] fixes/preparation for extjs7.0 Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526085839.9808-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox