public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lorenz Stechauner <l.stechauner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] fix #3440: influxdb: remove duplicate vmid tag
Date: Tue, 25 May 2021 15:27:17 +0200	[thread overview]
Message-ID: <20210525132717.108343-1-l.stechauner@proxmox.com> (raw)

remove vmid from data part, it is already contained in object part.

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
---
Tested with local udp listener. works as expected.

 PVE/Status/InfluxDB.pm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/PVE/Status/InfluxDB.pm b/PVE/Status/InfluxDB.pm
index 9e4b0d96..c50aa9c8 100644
--- a/PVE/Status/InfluxDB.pm
+++ b/PVE/Status/InfluxDB.pm
@@ -94,6 +94,8 @@ sub update_qemu_status {
     }
     $object =~ s/\s/\\ /g;
 
+    # Duplicate keys may result in unwanted behavior
+    delete $data->{vmid};
     build_influxdb_payload($class, $txn, $data, $ctime, $object);
 }
 
@@ -108,6 +110,8 @@ sub update_lxc_status {
     }
     $object =~ s/\s/\\ /g;
 
+    # Duplicate keys may result in unwanted behavior
+    delete $data->{vmid};
     build_influxdb_payload($class, $txn, $data, $ctime, $object);
 }
 
-- 
2.20.1





             reply	other threads:[~2021-05-25 13:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 13:27 Lorenz Stechauner [this message]
2021-05-26  7:46 ` Fabian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525132717.108343-1-l.stechauner@proxmox.com \
    --to=l.stechauner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal