From: Oguz Bektas <o.bektas@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container] fix #3443: setup: clear /etc/machine-id in post-create hook
Date: Tue, 25 May 2021 15:17:11 +0200 [thread overview]
Message-ID: <20210525131711.1007675-1-o.bektas@proxmox.com> (raw)
this way when new containers are created the will have a unique
/etc/machine-id
note that post_create_hook doesn't run for cloned containers so that
will need to be handled separately
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
src/PVE/LXC/Setup/Base.pm | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
index be41874..75a7f74 100644
--- a/src/PVE/LXC/Setup/Base.pm
+++ b/src/PVE/LXC/Setup/Base.pm
@@ -476,6 +476,18 @@ sub set_timezone {
}
}
+sub clear_machine_id {
+ my ($self, $conf) = @_;
+
+ my $dbus_machine_id_path = "/var/lib/dbus/machine-id";
+ my $machine_id_path = "/etc/machine-id";
+ if ($self->ct_file_exists($dbus_machine_id_path)) {
+ $self->ct_unlink($dbus_machine_id_path);
+ }
+ $self->ct_unlink($machine_id_path);
+ $self->ct_file_set_contents($machine_id_path, "uninitialized\n");
+}
+
sub pre_start_hook {
my ($self, $conf) = @_;
@@ -491,6 +503,7 @@ sub pre_start_hook {
sub post_create_hook {
my ($self, $conf, $root_password, $ssh_keys) = @_;
+ $self->clear_machine_id($conf);
$self->template_fixup($conf);
$self->randomize_crontab($conf);
--
2.20.1
next reply other threads:[~2021-05-25 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 13:17 Oguz Bektas [this message]
2021-05-25 13:45 ` Thomas Lamprecht
2021-05-26 9:40 ` Oguz Bektas
2021-05-26 9:46 ` Oguz Bektas
2021-05-26 10:00 ` Thomas Lamprecht
2021-05-26 10:03 ` Oguz Bektas
2021-05-26 10:07 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525131711.1007675-1-o.bektas@proxmox.com \
--to=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox