From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 3/3] ui: ResourceGrid: correctly remove ResourceStore listener
Date: Thu, 20 May 2021 16:59:16 +0200 [thread overview]
Message-ID: <20210520145916.23222-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210520145916.23222-1-d.csapak@proxmox.com>
while the function in '.on' and '.un' are identical, they are not the
*same* function, thus the '.un' does not really remove the listener,
and we have leftover references to the grid which means it will never
really garbage-collected
instead, use '.mon' on the grid, which automatically cleans up the
listeners
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/grid/ResourceGrid.js | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/www/manager6/grid/ResourceGrid.js b/www/manager6/grid/ResourceGrid.js
index c6757e9b..07048b88 100644
--- a/www/manager6/grid/ResourceGrid.js
+++ b/www/manager6/grid/ResourceGrid.js
@@ -125,14 +125,11 @@ Ext.define('PVE.grid.ResourceGrid', {
var ws = me.up('pveStdWorkspace');
ws.selectById(record.data.id);
},
- destroy: function() {
- rstore.un("load", () => updateGrid());
- },
},
columns: rstore.defaultColumns(),
});
me.callParent();
updateGrid();
- rstore.on("load", () => updateGrid());
+ me.mon(rstore, 'load', () => updateGrid());
},
});
--
2.20.1
next prev parent reply other threads:[~2021-05-20 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 14:59 [pve-devel] [PATCH manager 0/3] some small ui fixes Dominik Csapak
2021-05-20 14:59 ` [pve-devel] [PATCH manager 1/3] ui: Parser: fix bind and dev mounts for lxc Dominik Csapak
2021-05-20 14:59 ` [pve-devel] [PATCH manager 2/3] ui: dc/RoleView: add variableRowHeight Dominik Csapak
2021-05-20 14:59 ` Dominik Csapak [this message]
2021-05-20 19:05 ` [pve-devel] applied-series: [PATCH manager 0/3] some small ui fixes Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520145916.23222-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox