[pve-devel] [PATCH-SERIES manager/docs] add warning for disabling or deleting users

[pve-devel] [PATCH-SERIES manager/docs] add warning for disabling or deleting users

[Lorenz Stechauner]

see #3101 - NoVNC runs in the background when the user is disabled

these patches add a warning in docs and the user edit window
to warn admins that disabling a user will not terminate any
running worker.


manager:

Lorenz Stechauner (1):
  ui: dc/UserEdit: add warning for disabling users

 www/manager6/dc/UserEdit.js | 14 ++++++++++++++
 1 file changed, 14 insertions(+)


docs:

Lorenz Stechauner (1):
  pveum: add warning for disabling or deleting users

 pveum.adoc | 5 +++++
 1 file changed, 5 insertions(+)
-- 
2.20.1

[pve-devel] [PATCH manager 1/1] ui: dc/UserEdit: add warning for disabling users

[Lorenz Stechauner]

see #3101

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
---
 www/manager6/dc/UserEdit.js | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/www/manager6/dc/UserEdit.js b/www/manager6/dc/UserEdit.js
index b637cd53..65a612fd 100644
--- a/www/manager6/dc/UserEdit.js
+++ b/www/manager6/dc/UserEdit.js
@@ -73,6 +73,12 @@ Ext.define('PVE.dc.UserEdit', {
 		uncheckedValue: 0,
 		defaultValue: 1,
 		checked: true,
+		listeners: {
+		    change: function(checkbox) {
+			let taskWarning = me.lookup('taskWarning');
+			taskWarning.setHidden(!(me.wasEnabled && !checkbox.value));
+		    },
+		},
 	    },
 	];
 
@@ -93,6 +99,13 @@ Ext.define('PVE.dc.UserEdit', {
 		fieldLabel: gettext('E-Mail'),
 		vtype: 'proxmoxMail',
 	    },
+	    {
+		xtype: 'displayfield',
+		reference: 'taskWarning',
+		userCls: 'pmx-hint',
+		value: gettext('Note: Already running tasks of user will not be terminated automatically!'),
+		hidden: true,
+	    },
 	];
 
 	if (me.isCreate) {
@@ -161,6 +174,7 @@ Ext.define('PVE.dc.UserEdit', {
 		success: function(response, options) {
 		    var data = response.result.data;
 		    me.setValues(data);
+		    me.wasEnabled = data.enable;
 		    if (data.keys) {
 			if (data.keys === 'x!oath' || data.keys === 'x!u2f') {
 			    me.down('[name="keys"]').setDisabled(1);
-- 
2.20.1

[pve-devel] [PATCH docs 1/1] pveum: add warning for disabling or deleting users

[Lorenz Stechauner]

see #3101

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
---
 pveum.adoc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/pveum.adoc b/pveum.adoc
index 7120db7..0bece8a 100644
--- a/pveum.adoc
+++ b/pveum.adoc
@@ -56,6 +56,11 @@ Each user entry in this file contains the following information:
 * Whether this user is enabled or disabled
 * Optional two-factor authentication keys
 
+CAUTION: After disabling or deleting a user, this user will not be able to
+log in to new sessions or start new tasks. But all tasks which already have
+been started by this user (e.g. terminal sessions) will **not** be
+terminated automatically.
+
 
 System administrator
 ~~~~~~~~~~~~~~~~~~~~
-- 
2.20.1

Re: [pve-devel] [PATCH docs 1/1] pveum: add warning for disabling or deleting users

[Thomas Lamprecht]

On 20.05.21 15:53, Lorenz Stechauner wrote:
> see #3101
> 
> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
> ---
>  pveum.adoc | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/pveum.adoc b/pveum.adoc
> index 7120db7..0bece8a 100644
> --- a/pveum.adoc
> +++ b/pveum.adoc
> @@ -56,6 +56,11 @@ Each user entry in this file contains the following information:
>  * Whether this user is enabled or disabled
>  * Optional two-factor authentication keys
>  
> +CAUTION: After disabling or deleting a user, this user will not be able to
> +log in to new sessions or start new tasks. But all tasks which already have
> +been started by this user (e.g. terminal sessions) will **not** be

See the internal style guide regarding some style rules we want to enforce for
new additions (and slowly change over existing ones), here the section regarding
e.g./i.e.:

https://intranet.proxmox.com/index.php/Technical_Writing_Style_Guide#e.g..2Fi.e.

But the whole thing is not that long, so I'd really recommend giving it a full
read.

> +terminated automatically.



> +
>  
>  System administrator
>  ~~~~~~~~~~~~~~~~~~~~
>