From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/5] ui: panel/IPSet: eslint fixes
Date: Wed, 19 May 2021 12:56:19 +0200 [thread overview]
Message-ID: <20210519105622.6514-2-d.jaeger@proxmox.com> (raw)
In-Reply-To: <20210519105622.6514-1-d.jaeger@proxmox.com>
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
www/manager6/panel/IPSet.js | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/www/manager6/panel/IPSet.js b/www/manager6/panel/IPSet.js
index 303e518a..94117789 100644
--- a/www/manager6/panel/IPSet.js
+++ b/www/manager6/panel/IPSet.js
@@ -22,11 +22,11 @@ Ext.define('PVE.IPSetList', {
initComponent: function() {
var me = this;
- if (me.ipset_panel == undefined) {
+ if (typeof me.ipset_panel === 'undefined') {
throw "no rule panel specified";
}
- if (me.base_url == undefined) {
+ if (typeof me.ipset_panel === 'undefined') {
throw "no base_url specified";
}
@@ -143,7 +143,7 @@ Ext.define('PVE.IPSetList', {
],
listeners: {
itemdblclick: run_editor,
- select: function(sm, rec) {
+ select: function(_, rec) {
var url = me.base_url + '/' + rec.data.name;
me.ipset_panel.setBaseUrl(url);
},
@@ -346,7 +346,7 @@ Ext.define('PVE.IPSetGrid', {
metaData.tdCls = 'proxmox-invalid-row';
var html = '<p>' + Ext.htmlEncode(msg) + '</p>';
metaData.tdAttr = 'data-qwidth=600 data-qtitle="ERROR" data-qtip="' +
- html.replace(/\"/g, '"') + '"';
+ html.replace(/"/g, '"') + '"';
}
}
return value;
--
2.20.1
next prev parent reply other threads:[~2021-05-19 10:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 10:56 [pve-devel] [PATCH manager 1/5] ui: panel/ConfigPanel: " Dominic Jäger
2021-05-19 10:56 ` Dominic Jäger [this message]
2021-05-19 10:56 ` [pve-devel] [PATCH manager 3/5] ui: panel/NotesView: " Dominic Jäger
2021-05-19 10:56 ` [pve-devel] [PATCH manager 4/5] ui: panel/RunningChart: " Dominic Jäger
2021-05-19 10:56 ` [pve-devel] [PATCH manager 5/5] ui: panel/StatusPanel: " Dominic Jäger
2021-05-19 12:10 ` [pve-devel] applied-series: [PATCH manager 1/5] ui: panel/ConfigPanel: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519105622.6514-2-d.jaeger@proxmox.com \
--to=d.jaeger@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox