public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/2] ui: qemu: eslint fixes
Date: Wed, 19 May 2021 11:14:18 +0200	[thread overview]
Message-ID: <20210519091419.18921-1-d.jaeger@proxmox.com> (raw)

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
These 2 patches fix the remaining errors for manager6/qemu and manager6/storage
(manager6/lxc is already OK)

 www/manager6/qemu/CmdMenu.js | 2 +-
 www/manager6/qemu/PCIEdit.js | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/www/manager6/qemu/CmdMenu.js b/www/manager6/qemu/CmdMenu.js
index e312119d..fa75ad82 100644
--- a/www/manager6/qemu/CmdMenu.js
+++ b/www/manager6/qemu/CmdMenu.js
@@ -85,7 +85,7 @@ Ext.define('PVE.qemu.CmdMenu', {
 		text: gettext('Shutdown'),
 		iconCls: 'fa fa-fw fa-power-off',
 		disabled: stopped || suspended,
-		handler: () =>  confirmedVMCommand('shutdown'),
+		handler: () => confirmedVMCommand('shutdown'),
 	    },
 	    {
 		text: gettext('Stop'),
diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js
index 942e8aed..a8e05f2d 100644
--- a/www/manager6/qemu/PCIEdit.js
+++ b/www/manager6/qemu/PCIEdit.js
@@ -124,11 +124,14 @@ Ext.define('PVE.qemu.PCIInputPanel', {
 			if (iommu !== -1) {
 			    var count = 0;
 			    pcisel.getStore().each(function(record) {
-				if (record.data.iommugroup === iommu &&
-				    record.data.id.substring(0, 5) !== id) {
+				if (
+				    record.data.iommugroup === iommu &&
+				    record.data.id.substring(0, 5) !== id
+				) {
 				    count++;
 				    return false;
 				}
+				return true;
 			    });
 			    var warning = me.down('#iommuwarning');
 			    if (count && !warning) {
-- 
2.20.1





             reply	other threads:[~2021-05-19  9:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19  9:14 Dominic Jäger [this message]
2021-05-19  9:14 ` [pve-devel] [PATCH manager 2/2] ui: storage/PBS edit: " Dominic Jäger
2021-05-19 10:30 ` [pve-devel] applied: [PATCH manager 1/2] ui: qemu: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519091419.18921-1-d.jaeger@proxmox.com \
    --to=d.jaeger@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal