From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 3/6] Functions may not be completely empty
Date: Tue, 18 May 2021 14:12:15 +0200 [thread overview]
Message-ID: <20210518121218.125661-4-d.jaeger@proxmox.com> (raw)
In-Reply-To: <20210518121218.125661-1-d.jaeger@proxmox.com>
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
www/manager6/storage/GlusterFsEdit.js | 1 +
www/manager6/storage/IScsiEdit.js | 1 +
www/manager6/storage/LvmThinEdit.js | 1 +
www/manager6/storage/NFSEdit.js | 1 +
www/manager6/storage/StatusView.js | 2 +-
5 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/www/manager6/storage/GlusterFsEdit.js b/www/manager6/storage/GlusterFsEdit.js
index 4ea5da26..8155d9c2 100644
--- a/www/manager6/storage/GlusterFsEdit.js
+++ b/www/manager6/storage/GlusterFsEdit.js
@@ -12,6 +12,7 @@ Ext.define('PVE.storage.GlusterFsScan', {
width: 350,
},
doRawQuery: function() {
+ // nothing
},
onTriggerClick: function() {
diff --git a/www/manager6/storage/IScsiEdit.js b/www/manager6/storage/IScsiEdit.js
index c5afa53b..341e0535 100644
--- a/www/manager6/storage/IScsiEdit.js
+++ b/www/manager6/storage/IScsiEdit.js
@@ -11,6 +11,7 @@ Ext.define('PVE.storage.IScsiScan', {
width: 350,
},
doRawQuery: function() {
+ // do nothing
},
onTriggerClick: function() {
diff --git a/www/manager6/storage/LvmThinEdit.js b/www/manager6/storage/LvmThinEdit.js
index 97248f11..4eab7740 100644
--- a/www/manager6/storage/LvmThinEdit.js
+++ b/www/manager6/storage/LvmThinEdit.js
@@ -8,6 +8,7 @@ Ext.define('PVE.storage.TPoolSelector', {
editable: false,
doRawQuery: function() {
+ // nothing
},
onTriggerClick: function() {
diff --git a/www/manager6/storage/NFSEdit.js b/www/manager6/storage/NFSEdit.js
index a1be8e74..faa41732 100644
--- a/www/manager6/storage/NFSEdit.js
+++ b/www/manager6/storage/NFSEdit.js
@@ -12,6 +12,7 @@ Ext.define('PVE.storage.NFSScan', {
width: 350,
},
doRawQuery: function() {
+ // do nothing
},
onTriggerClick: function() {
diff --git a/www/manager6/storage/StatusView.js b/www/manager6/storage/StatusView.js
index 90631b0b..6a5ba36f 100644
--- a/www/manager6/storage/StatusView.js
+++ b/www/manager6/storage/StatusView.js
@@ -66,6 +66,6 @@ Ext.define('PVE.storage.StatusView', {
],
updateTitle: function() {
- return;
+ // nothing
},
});
--
2.20.1
next prev parent reply other threads:[~2021-05-18 12:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 12:12 [pve-devel] [PATCH manager 0/6] eslint fixes Dominic Jäger
2021-05-18 12:12 ` [pve-devel] [PATCH manager 1/6] Fix usage of 'me' Dominic Jäger
2021-05-18 12:12 ` [pve-devel] [PATCH manager 2/6] No unused or duplicate variables Dominic Jäger
2021-05-18 12:12 ` Dominic Jäger [this message]
2021-05-18 12:12 ` [pve-devel] [PATCH manager 4/6] Remove useless escapes Dominic Jäger
2021-05-18 12:12 ` [pve-devel] [PATCH manager 5/6] State equalities more precisely Dominic Jäger
2021-05-18 12:12 ` [pve-devel] [PATCH manager 6/6] Miscellaneous eslint fixes Dominic Jäger
2021-05-18 13:23 ` [pve-devel] applied-series: [PATCH manager 0/6] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518121218.125661-4-d.jaeger@proxmox.com \
--to=d.jaeger@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox