public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH http-server 0/2] remove unnecessary websocket code
Date: Mon, 17 May 2021 15:07:33 +0200	[thread overview]
Message-ID: <20210517130735.17568-1-d.csapak@proxmox.com> (raw)

we do not need/want any websocket subprotocol handling, nor do
we need 'base64' encoding/decoding, so drop it

we can drop the protocols in the clients (novnc/xtermjs) with
the next major release after this is released, else the cluster console
will not work. the compatibility code here can then be dropped one major
release after

so if we opt to apply it now for 6.4 still, we may get away with
dropping the client protocol for 7.x, and the compat code with 8.0

else we have to wait for 8.0 to drop the client code, and 9.0
for the compat code

Dominik Csapak (2):
  AnyEvent/websocket_proxy: remove 'base64' handling
  AnyEvent/websocket_proxy: drop handling of websocket subprotocols

 src/PVE/APIServer/AnyEvent.pm | 34 +++++++---------------------------
 1 file changed, 7 insertions(+), 27 deletions(-)

-- 
2.20.1





             reply	other threads:[~2021-05-17 13:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 13:07 Dominik Csapak [this message]
2021-05-17 13:07 ` [pve-devel] [PATCH http-server 1/2] AnyEvent/websocket_proxy: remove 'base64' handling Dominik Csapak
2021-05-17 13:07 ` [pve-devel] [PATCH http-server 2/2] AnyEvent/websocket_proxy: drop handling of websocket subprotocols Dominik Csapak
2021-05-18  8:33 ` [pve-devel] applied-series: [PATCH http-server 0/2] remove unnecessary websocket code Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210517130735.17568-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal