From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 5/9] cli tools: correctly handle warnings status
Date: Wed, 12 May 2021 14:32:54 +0200 [thread overview]
Message-ID: <20210512123258.28178-6-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210512123258.28178-1-f.ebner@proxmox.com>
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
PVE/CLI/pveceph.pm | 2 +-
PVE/CLI/pvenode.pm | 2 +-
PVE/CLI/vzdump.pm | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm
index 2745cc62..c02dc3fe 100755
--- a/PVE/CLI/pveceph.pm
+++ b/PVE/CLI/pveceph.pm
@@ -35,7 +35,7 @@ my $nodename = PVE::INotify::nodename();
my $upid_exit = sub {
my $upid = shift;
my $status = PVE::Tools::upid_read_status($upid);
- exit($status eq 'OK' ? 0 : -1);
+ exit(PVE::Tools::upid_status_is_error($status) ? -1 : 0);
};
sub setup_environment {
diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm
index b05b3e15..acef6c3b 100644
--- a/PVE/CLI/pvenode.pm
+++ b/PVE/CLI/pvenode.pm
@@ -36,7 +36,7 @@ my $upid_exit = sub {
my $upid = shift;
my $status = PVE::Tools::upid_read_status($upid);
print "Task $status\n";
- exit($status eq 'OK' ? 0 : -1);
+ exit(PVE::Tools::upid_status_is_error($status) ? -1 : 0);
};
sub param_mapping {
diff --git a/PVE/CLI/vzdump.pm b/PVE/CLI/vzdump.pm
index fe5fd049..3f625574 100755
--- a/PVE/CLI/vzdump.pm
+++ b/PVE/CLI/vzdump.pm
@@ -19,7 +19,7 @@ our $cmddef = [ 'PVE::API2::VZDump', 'vzdump', 'vmid', undef,
my $upid = shift;
exit(0) if $upid eq 'OK';
my $status = PVE::Tools::upid_read_status($upid);
- exit($status eq 'OK' ? 0 : -1);
+ exit(PVE::Tools::upid_status_is_error($status) ? -1 : 0);
}];
1;
--
2.20.1
next prev parent reply other threads:[~2021-05-12 12:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 12:32 [pve-devel] [PATCH-SERIES] " Fabian Ebner
2021-05-12 12:32 ` [pve-devel] [PATCH common 1/9] tools: add upid_status_is_error function Fabian Ebner
2021-06-17 13:23 ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH manager 2/9] api/cli: tasks: don't treat warnings status as an error status Fabian Ebner
2021-06-24 7:06 ` Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH manager 3/9] nodes: startall: correctly handle warning status for delayed task Fabian Ebner
2021-06-24 7:04 ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH manager 4/9] cli: pveam: remove unused private sub Fabian Ebner
2021-06-24 7:04 ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` Fabian Ebner [this message]
2021-06-24 7:04 ` [pve-devel] applied: [PATCH manager 5/9] cli tools: correctly handle warnings status Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH storage 6/9] api: content: correctly handle warnings status for delayed task Fabian Ebner
2021-06-23 20:22 ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH container 7/9] pct: correctly handle warnings task status Fabian Ebner
2021-06-23 20:17 ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH qemu-server 8/9] cli tools: " Fabian Ebner
2021-06-23 10:53 ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH qemu-server 9/9] api: update vm: correctly handle warnings status for delayed task Fabian Ebner
2021-06-23 10:53 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210512123258.28178-6-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox