From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH common 1/9] tools: add upid_status_is_error function
Date: Wed, 12 May 2021 14:32:50 +0200 [thread overview]
Message-ID: <20210512123258.28178-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210512123258.28178-1-f.ebner@proxmox.com>
There's also support for ending a task with warnings now, so the logic "status
not 'OK' means error" does not work anymore.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
src/PVE/Tools.pm | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 16ae3d2..6f205df 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -1165,6 +1165,14 @@ sub upid_read_status {
return "unable to read tail (got $br bytes)";
}
+# Check if the status returned by upid_read_status is an error status.
+# If the status could not be parsed it's also treated as an error.
+sub upid_status_is_error {
+ my ($status) = @_;
+
+ return !($status eq 'OK' || $status =~ m/^WARNINGS: \d+$/);
+}
+
# useful functions to store comments in config files
sub encode_text {
my ($text) = @_;
--
2.20.1
next prev parent reply other threads:[~2021-05-12 12:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 12:32 [pve-devel] [PATCH-SERIES] correctly handle warnings status Fabian Ebner
2021-05-12 12:32 ` Fabian Ebner [this message]
2021-06-17 13:23 ` [pve-devel] applied: [PATCH common 1/9] tools: add upid_status_is_error function Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH manager 2/9] api/cli: tasks: don't treat warnings status as an error status Fabian Ebner
2021-06-24 7:06 ` Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH manager 3/9] nodes: startall: correctly handle warning status for delayed task Fabian Ebner
2021-06-24 7:04 ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH manager 4/9] cli: pveam: remove unused private sub Fabian Ebner
2021-06-24 7:04 ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH manager 5/9] cli tools: correctly handle warnings status Fabian Ebner
2021-06-24 7:04 ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH storage 6/9] api: content: correctly handle warnings status for delayed task Fabian Ebner
2021-06-23 20:22 ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH container 7/9] pct: correctly handle warnings task status Fabian Ebner
2021-06-23 20:17 ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH qemu-server 8/9] cli tools: " Fabian Ebner
2021-06-23 10:53 ` [pve-devel] applied: " Thomas Lamprecht
2021-05-12 12:32 ` [pve-devel] [PATCH qemu-server 9/9] api: update vm: correctly handle warnings status for delayed task Fabian Ebner
2021-06-23 10:53 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210512123258.28178-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox