[pve-devel] [PATCH manager] ui: set file name for spice console download in chrome

[pve-devel] [PATCH manager] ui: set file name for spice console download in chrome

[Lorenz Stechauner]

When the virt-viewer file is downloaded we already set
a file name in Android, so the file type may be
recognized. Also doing this in Chrome (and Chromium
based browsers) allows users to "alyways open files of
this type". So the browser automatically opens the
console window without user interaction.

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
---
 www/manager6/Utils.js | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index f502950f..35d49630 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1358,11 +1358,10 @@ Ext.define('PVE.Utils', {
 		css: 'display:none;visibility:hidden;height:0px;',
 	    });
 
-	    // Note: we need to tell android the correct file name extension
+	    // Note: we need to tell Android and Chrome the correct file name extension
 	    // but we do not set 'download' tag for other environments, because
 	    // It can have strange side effects (additional user prompt on firefox)
-	    var andriod = !!navigator.userAgent.match(/Android/i);
-	    if (andriod) {
+	    if (navigator.userAgent.match(/Android|Chrome/i)) {
 		link.download = name;
 	    }
 
-- 
2.20.1

[pve-devel] applied: [PATCH manager] ui: set file name for spice console download in chrome

[Thomas Lamprecht]

On 22.04.21 09:49, Lorenz Stechauner wrote:
> When the virt-viewer file is downloaded we already set
> a file name in Android, so the file type may be
> recognized. Also doing this in Chrome (and Chromium
> based browsers) allows users to "alyways open files of
> this type". So the browser automatically opens the
> console window without user interaction.
> 

note, this seems like a bit of a crammed commit message text-width wise.
I amended that to match the text-width = 69, as it should neither be overly
long, nor really short.

If you use vim for writing those I suggest adding a hunk like the following
to your vimrc:

au FileType gitcommit setlocal tw=69


> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
> ---
>  www/manager6/Utils.js | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
>

applied, thanks! Behavior is really better this way in Chrome/Chromium.
My Firefox here already worked fine, so seems not required for it anyway.