public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH docs 1/2] pveceph: also mention editing of pools
@ 2021-04-21 10:52 Dominik Csapak
  2021-04-21 10:52 ` [pve-devel] [PATCH docs 2/2] pveceph: order the fields according to gui Dominik Csapak
  2021-04-21 12:14 ` [pve-devel] applied: [PATCH docs 1/2] pveceph: also mention editing of pools Thomas Lamprecht
  0 siblings, 2 replies; 4+ messages in thread
From: Dominik Csapak @ 2021-04-21 10:52 UTC (permalink / raw)
  To: pve-devel

We can now edit them as well so write that.
Also mention that the 'add as storage' checkbox is only visible when
creating a pool.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 pveceph.adoc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pveceph.adoc b/pveceph.adoc
index 9ef268b..e15028a 100644
--- a/pveceph.adoc
+++ b/pveceph.adoc
@@ -450,8 +450,8 @@ A pool is a logical group for storing objects. It holds **P**lacement
 **G**roups (`PG`, `pg_num`), a collection of objects.
 
 
-Create Pools
-~~~~~~~~~~~~
+Create and edit Pools
+~~~~~~~~~~~~~~~~~~~~~
 
 [thumbnail="screenshot/gui-ceph-pools.png"]
 
@@ -497,7 +497,7 @@ PG Autoscale Mode:: The automatic PG scaling mode footnoteref:[autoscaler] of
 the pool. If set to `warn`, it produces a warning message when a pool
 has a non-optimal PG count. Default: `warn`.
 Add as Storage:: Configure a VM or container storage using the new pool.
-Default: `true`.
+Default: `true` (only visible on creation).
 
 .Advanced Options
 Min. Size:: The minimum number of replicas per object. Ceph will reject I/O on
-- 
2.20.1





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH docs 2/2] pveceph: order the fields according to gui
  2021-04-21 10:52 [pve-devel] [PATCH docs 1/2] pveceph: also mention editing of pools Dominik Csapak
@ 2021-04-21 10:52 ` Dominik Csapak
  2021-04-21 12:14   ` [pve-devel] applied: " Thomas Lamprecht
  2021-04-21 12:14 ` [pve-devel] applied: [PATCH docs 1/2] pveceph: also mention editing of pools Thomas Lamprecht
  1 sibling, 1 reply; 4+ messages in thread
From: Dominik Csapak @ 2021-04-21 10:52 UTC (permalink / raw)
  To: pve-devel

In the gui the order is different, so adpat the order here.
While we are at it fix the typo: s/Traget/Target/

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 pveceph.adoc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pveceph.adoc b/pveceph.adoc
index e15028a..2ac9ad7 100644
--- a/pveceph.adoc
+++ b/pveceph.adoc
@@ -508,11 +508,11 @@ xref:pve_ceph_device_classes[Ceph CRUSH & device classes] for information on
 device-based rules.
 # of PGs:: The number of placement groups footnoteref:[placement_groups] that
 the pool should have at the beginning. Default: `128`.
-Traget Size:: The estimated amount of data expected in the pool. The PG
-autoscaler uses this size to estimate the optimal PG count.
 Target Size Ratio:: The ratio of data that is expected in the pool. The PG
 autoscaler uses the ratio relative to other ratio sets. It takes precedence
 over the `target size` if both are set.
+Target Size:: The estimated amount of data expected in the pool. The PG
+autoscaler uses this size to estimate the optimal PG count.
 Min. # of PGs:: The minimum number of placement groups. This setting is used to
 fine-tune the lower bound of the PG count for that pool. The PG autoscaler
 will not merge PGs below this threshold.
-- 
2.20.1





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] applied: [PATCH docs 1/2] pveceph: also mention editing of pools
  2021-04-21 10:52 [pve-devel] [PATCH docs 1/2] pveceph: also mention editing of pools Dominik Csapak
  2021-04-21 10:52 ` [pve-devel] [PATCH docs 2/2] pveceph: order the fields according to gui Dominik Csapak
@ 2021-04-21 12:14 ` Thomas Lamprecht
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2021-04-21 12:14 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

On 21.04.21 12:52, Dominik Csapak wrote:
> We can now edit them as well so write that.
> Also mention that the 'add as storage' checkbox is only visible when
> creating a pool.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  pveceph.adoc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/pveceph.adoc b/pveceph.adoc
> index 9ef268b..e15028a 100644
> --- a/pveceph.adoc
> +++ b/pveceph.adoc
> @@ -450,8 +450,8 @@ A pool is a logical group for storing objects. It holds **P**lacement
>  **G**roups (`PG`, `pg_num`), a collection of objects.
>  
>  
> -Create Pools
> -~~~~~~~~~~~~
> +Create and edit Pools
> +~~~~~~~~~~~~~~~~~~~~~
>  

applied, but changed to our used title-case in a followup.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] applied: [PATCH docs 2/2] pveceph: order the fields according to gui
  2021-04-21 10:52 ` [pve-devel] [PATCH docs 2/2] pveceph: order the fields according to gui Dominik Csapak
@ 2021-04-21 12:14   ` Thomas Lamprecht
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2021-04-21 12:14 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

On 21.04.21 12:52, Dominik Csapak wrote:
> In the gui the order is different, so adpat the order here.
> While we are at it fix the typo: s/Traget/Target/
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  pveceph.adoc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-04-21 12:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 10:52 [pve-devel] [PATCH docs 1/2] pveceph: also mention editing of pools Dominik Csapak
2021-04-21 10:52 ` [pve-devel] [PATCH docs 2/2] pveceph: order the fields according to gui Dominik Csapak
2021-04-21 12:14   ` [pve-devel] applied: " Thomas Lamprecht
2021-04-21 12:14 ` [pve-devel] applied: [PATCH docs 1/2] pveceph: also mention editing of pools Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal