From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 3/7] ui: add SafeDestroyGuest window
Date: Mon, 19 Apr 2021 15:14:37 +0200 [thread overview]
Message-ID: <20210419131441.23650-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210419131441.23650-1-f.ebner@proxmox.com>
The purge parameter is always explicitly set, which is different from the
existing behavior, but it does not rely on what the default in the backend is.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
Dependency bump for proxmox-widget-toolkit is needed.
www/manager6/Makefile | 1 +
www/manager6/window/SafeDestroyGuest.js | 30 +++++++++++++++++++++++++
2 files changed, 31 insertions(+)
create mode 100644 www/manager6/window/SafeDestroyGuest.js
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index a2f7be6d..6fc4cde5 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -100,6 +100,7 @@ JSSRC= \
window/Prune.js \
window/Restore.js \
window/SafeDestroy.js \
+ window/SafeDestroyGuest.js \
window/Settings.js \
window/Snapshot.js \
window/StartupEdit.js \
diff --git a/www/manager6/window/SafeDestroyGuest.js b/www/manager6/window/SafeDestroyGuest.js
new file mode 100644
index 00000000..d6121594
--- /dev/null
+++ b/www/manager6/window/SafeDestroyGuest.js
@@ -0,0 +1,30 @@
+/*
+ * SafeDestroy window with additional checkboxes for removing guests
+ */
+Ext.define('PVE.window.SafeDestroyGuest', {
+ extend: 'Proxmox.window.SafeDestroy',
+ alias: 'proxmoxSafeDestroy',
+
+ additionalItems: [
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'purge',
+ reference: 'purgeCheckbox',
+ boxLabel: gettext('Purge'),
+ checked: false,
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext('Remove from replication and backup jobs'),
+ },
+ },
+ ],
+
+ getParams: function() {
+ let me = this;
+
+ const purgeCheckbox = me.lookupReference('purgeCheckbox');
+ me.params.purge = purgeCheckbox.checked ? 1 : 0;
+
+ return me.callParent();
+ },
+});
--
2.20.1
next prev parent reply other threads:[~2021-04-19 13:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 13:14 [pve-devel] [PATCH-SERIES widget-toolkit/manager] Add checkbox for removing unreferenced disks on guest removal Fabian Ebner
2021-04-19 13:14 ` [pve-devel] [PATCH proxmox-widget-toolkit 1/7] safe destroy: remove purge checkbox Fabian Ebner
2021-04-19 13:14 ` [pve-devel] [PATCH proxmox-widget-toolkit 2/7] safe destroy: allow specifing additional items Fabian Ebner
2021-04-19 13:14 ` Fabian Ebner [this message]
2021-04-19 13:14 ` [pve-devel] [PATCH manager 4/7] ui: use new SafeDestroyGuest window Fabian Ebner
2021-04-19 13:14 ` [pve-devel] [PATCH manager 5/7] ui: safe destroy guest: add checkbox for removal of unreferenced disks Fabian Ebner
2021-04-19 13:14 ` [pve-devel] [PATCH manager 6/7] ui: use safe destroy window from proxmox-widget-toolkit Fabian Ebner
2021-04-19 13:14 ` [pve-devel] [PATCH manager 7/7] ui: remove SafeDestroy window Fabian Ebner
2021-04-22 18:45 ` [pve-devel] applied: [PATCH-SERIES widget-toolkit/manager] Add checkbox for removing unreferenced disks on guest removal Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419131441.23650-4-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox