public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-widget-toolkit 1/7] safe destroy: remove purge checkbox
Date: Mon, 19 Apr 2021 15:14:35 +0200	[thread overview]
Message-ID: <20210419131441.23650-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210419131441.23650-1-f.ebner@proxmox.com>

To be replaced by generic additional items specified by the user of the window
or child class. AFAICS there are no existing users of this widget yet, so this
shouldn't break anything.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 src/window/SafeDestroy.js | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js
index 87f81b7..91e0f2c 100644
--- a/src/window/SafeDestroy.js
+++ b/src/window/SafeDestroy.js
@@ -18,7 +18,6 @@ Ext.define('Proxmox.window.SafeDestroy', {
     config: {
 	item: {
 	    id: undefined,
-	    purgeable: false,
 	},
 	url: undefined,
 	note: undefined,
@@ -28,10 +27,7 @@ Ext.define('Proxmox.window.SafeDestroy', {
 
     getParams: function() {
 	let me = this;
-	const purgeCheckbox = me.lookupReference('purgeCheckbox');
-	if (purgeCheckbox.checked) {
-	    me.params.purge = 1;
-	}
+
 	if (Ext.Object.isEmpty(me.params)) {
 	    return '';
 	}
@@ -128,17 +124,6 @@ Ext.define('Proxmox.window.SafeDestroy', {
 		    hideTrigger: true,
 		    allowBlank: false,
 		},
-		{
-		    xtype: 'proxmoxcheckbox',
-		    name: 'purge',
-		    reference: 'purgeCheckbox',
-		    boxLabel: gettext('Purge'),
-		    checked: false,
-		    autoEl: {
-			tag: 'div',
-			'data-qtip': gettext('Remove from replication and backup jobs'),
-		    },
-		},
 		{
 		    xtype: 'container',
 		    reference: 'noteContainer',
@@ -198,12 +183,6 @@ Ext.define('Proxmox.window.SafeDestroy', {
 	    throw "no task name specified";
 	}
 
-	if (!item.purgeable) {
-	    const purgeCheckbox = me.lookupReference('purgeCheckbox');
-	    purgeCheckbox.setDisabled(true);
-	    purgeCheckbox.setHidden(true);
-	}
-
 	const confirmField = me.lookupReference('confirmField');
 	msg = gettext('Please enter the ID to confirm') +
 	    ' (' + item.id + ')';
-- 
2.20.1





  reply	other threads:[~2021-04-19 13:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19 13:14 [pve-devel] [PATCH-SERIES widget-toolkit/manager] Add checkbox for removing unreferenced disks on guest removal Fabian Ebner
2021-04-19 13:14 ` Fabian Ebner [this message]
2021-04-19 13:14 ` [pve-devel] [PATCH proxmox-widget-toolkit 2/7] safe destroy: allow specifing additional items Fabian Ebner
2021-04-19 13:14 ` [pve-devel] [PATCH manager 3/7] ui: add SafeDestroyGuest window Fabian Ebner
2021-04-19 13:14 ` [pve-devel] [PATCH manager 4/7] ui: use new " Fabian Ebner
2021-04-19 13:14 ` [pve-devel] [PATCH manager 5/7] ui: safe destroy guest: add checkbox for removal of unreferenced disks Fabian Ebner
2021-04-19 13:14 ` [pve-devel] [PATCH manager 6/7] ui: use safe destroy window from proxmox-widget-toolkit Fabian Ebner
2021-04-19 13:14 ` [pve-devel] [PATCH manager 7/7] ui: remove SafeDestroy window Fabian Ebner
2021-04-22 18:45 ` [pve-devel] applied: [PATCH-SERIES widget-toolkit/manager] Add checkbox for removing unreferenced disks on guest removal Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210419131441.23650-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal