public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC series 0/2] Show more vlan infos
Date: Mon, 12 Apr 2021 15:14:36 +0200	[thread overview]
Message-ID: <20210412131438.15859-1-a.lauterer@proxmox.com> (raw)

The main motivation here is to make the VLAN tags configured for an
interface better visible. The approach taken in this RFC is to use the
already existing vlan-id and vlan-raw-device values. These were only
present if the vlan device was configured with those explicit options,
available with ifupdown2.

For the other way, using the dot notation, the type was detected
correctly, but no further information about the vlan id and the used
device was present. Therefore the Inotify.pm has been changed to set the
same values for the dot notation interfaces. This results in the API
delivering the same information, not matter which type of vlan interface
it is.

Since the vlan-id and vlan-raw-device values are filtered for dot
notation interfaces when writing out the network config, I don't see
much harm here.

But should this approach be problematic for some reason that I have not
yet discovered, there is an alternative approach handling this in the
GUI only. Then the GUI would show the same information for both type of
vlan interfaces but the API would stay the same.

widget-toolkit: Aaron Lauterer (1):
  ui: network: add columns for vlan-id and vlan-raw-device

 src/node/NetworkView.js | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

pve-common:  src/PVE/INotify.pm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)


-- 
2.20.1





             reply	other threads:[~2021-04-12 13:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 13:14 Aaron Lauterer [this message]
2021-04-12 13:14 ` [pve-devel] [PATCH widget-toolkit 1/2] ui: network: add columns for vlan-id and vlan-raw-device Aaron Lauterer
2021-06-15 15:01   ` [pve-devel] applied: " Thomas Lamprecht
2021-04-12 13:14 ` [pve-devel] [PATCH common 2/2] inotify: read_interfaces: add vlan-id and vlan-raw-device on dot notation vlan interfaces Aaron Lauterer
2021-06-15 15:01   ` [pve-devel] applied: " Thomas Lamprecht
2021-06-09 13:38 ` [pve-devel] [RFC series 0/2] Show more vlan infos Aaron Lauterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210412131438.15859-1-a.lauterer@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal