From: Oguz Bektas <o.bektas@proxmox.com>
To: pve-devel@lists.proxmox.com, pve-devel@pve.proxmox.com
Subject: [pve-devel] [PATCH v4 common 1/3] daemon: listen also on ipv6
Date: Wed, 24 Mar 2021 14:20:36 +0100 [thread overview]
Message-ID: <20210324132036.592880-1-o.bektas@proxmox.com> (raw)
In-Reply-To: <99c76ae4-0810-f44d-25c4-3cdf8ce28dc0@proxmox.com>
see [0]
when we set 'Domain' to PF_INET6 by default, it will prefer IPv6. since
we don't set 'V6Only' it will also listen on IPv4 interfaces.
'Family' parameter isn't needed anymore.
this change depends on the changes in pve-manager and pve-http-server to
work correctly.
[0]:
https://perldoc.perl.org/IO::Socket::IP#REPLACING-IO::Socket-DEFAULT-BEHAVIOUR
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
v3->v4:
* remove $family parameter
src/PVE/Daemon.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/PVE/Daemon.pm b/src/PVE/Daemon.pm
index 64f8126..905635a 100644
--- a/src/PVE/Daemon.pm
+++ b/src/PVE/Daemon.pm
@@ -799,7 +799,7 @@ sub register_status_command {
# some useful helper
sub create_reusable_socket {
- my ($self, $port, $host, $family) = @_;
+ my ($self, $port, $host) = @_;
die "no port specifed" if !$port;
@@ -820,10 +820,10 @@ sub create_reusable_socket {
} else {
$socket = IO::Socket::IP->new(
- LocalAddr => $host,
+ Domain => PF_INET6,
+ LocalHost => $host,
LocalPort => $port,
Listen => SOMAXCONN,
- Family => $family,
Proto => 'tcp',
GetAddrInfoFlags => 0,
ReuseAddr => 1) ||
--
2.20.1
next prev parent reply other threads:[~2021-03-24 13:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 14:00 [pve-devel] [PATCH v3 http-server common manager 0/3] fix #2997: pveproxy LISTEN address Oguz Bektas
2021-03-22 14:00 ` [pve-devel] [PATCH v3 common 1/3] daemon: listen also on ipv6 Oguz Bektas
2021-03-24 8:37 ` Fabian Ebner
2021-03-24 10:38 ` Oguz Bektas
2021-03-24 11:00 ` Fabian Ebner
2021-03-24 12:59 ` [pve-devel] [PATCH pmg-api] pmgproxy: allow setting LISTEN_IP parameter Oguz Bektas
2021-03-24 13:20 ` Oguz Bektas [this message]
2021-04-21 16:16 ` [pve-devel] applied: [PATCH v4 common 1/3] daemon: listen also on ipv6 Thomas Lamprecht
2021-03-22 14:00 ` [pve-devel] [PATCH v3 manager 2/3] proxy: allow setting LISTEN_IP for pveproxy and spiceproxy Oguz Bektas
2021-03-24 8:37 ` Fabian Ebner
2021-03-24 10:03 ` Oguz Bektas
2021-03-22 14:00 ` [pve-devel] [PATCH v3 http-server 3/3] utils: add LISTEN_IP option in /etc/default/pveproxy Oguz Bektas
2021-03-23 13:30 ` Dylan Whyte
2021-04-21 15:44 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324132036.592880-1-o.bektas@proxmox.com \
--to=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=pve-devel@pve.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox