public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH storage] fix #3363: avoid undef-warning for PBS crypt-mode
@ 2021-03-24 12:24 Fabian Grünbichler
  2021-03-31  8:25 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Grünbichler @ 2021-03-24 12:24 UTC (permalink / raw)
  To: pve-devel

it is optional after all, and missing (/None) for files stored in the
snapshot dir but not referenced in the manifest for whatever reason.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 PVE/Storage/PBSPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm
index 6c6816e..df3aaab 100644
--- a/PVE/Storage/PBSPlugin.pm
+++ b/PVE/Storage/PBSPlugin.pm
@@ -527,7 +527,7 @@ my sub snapshot_files_encrypted {
 	my $crypt = $file->{'crypt-mode'};
 
 	$all = 0 if !$crypt || $crypt ne 'encrypt';
-	$any ||= $crypt eq 'encrypt';
+	$any ||= defined($crypt) && $crypt eq 'encrypt';
     }
     return $any && $all;
 }
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH storage] fix #3363: avoid undef-warning for PBS crypt-mode
  2021-03-24 12:24 [pve-devel] [PATCH storage] fix #3363: avoid undef-warning for PBS crypt-mode Fabian Grünbichler
@ 2021-03-31  8:25 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-03-31  8:25 UTC (permalink / raw)
  To: Proxmox VE development discussion, Fabian Grünbichler

On 24.03.21 13:24, Fabian Grünbichler wrote:
> it is optional after all, and missing (/None) for files stored in the
> snapshot dir but not referenced in the manifest for whatever reason.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>  PVE/Storage/PBSPlugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-31  8:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 12:24 [pve-devel] [PATCH storage] fix #3363: avoid undef-warning for PBS crypt-mode Fabian Grünbichler
2021-03-31  8:25 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal